chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc - Issue 2461463002: [Sync] Replacing NULL with nullptr/null throughout sync code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

Issue 2461463002: [Sync] Replacing NULL with nullptr/null throughout sync code. (Closed)

Patch Set: Reverted PROFILE_nullptr mistake. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/test/integration/profile_sync_service_harness.cc ('k') | chrome/browser/sync/test/integration/sync_app_list_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc b/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

index eae1d73132cb1a12239583a2eba3937287c92e66..87a39182747b709ed16404eeb62f4ad11541d9ba 100644

--- a/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

+++ b/chrome/browser/sync/test/integration/single_client_bookmarks_sync_test.cc

@@ -134,7 +134,7 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, Sanity) {

const BookmarkNode* bar = GetBookmarkBarNode(kSingleProfileIndex);

const BookmarkNode* cnn = AddURL(

kSingleProfileIndex, bar, 0, "CNN", GURL("http://www.cnn.com"));

- ASSERT_TRUE(cnn != NULL);

+ ASSERT_TRUE(cnn != nullptr);

Move(kSingleProfileIndex, tier1_a, bar, 1);

// Wait for the bookmark position change to sync.

@@ -160,12 +160,12 @@ IN_PROC_BROWSER_TEST_F(SingleClientBookmarksSyncTest, Sanity) {

const BookmarkNode* boa = AddURL(

kSingleProfileIndex, bar, bar->child_count(),

"Bank of America", GURL("https://www.bankofamerica.com"));

- ASSERT_TRUE(boa != NULL);

+ ASSERT_TRUE(boa != nullptr);

Move(kSingleProfileIndex, tier1_a_url0, top, top->child_count());

const BookmarkNode* bubble = AddURL(

kSingleProfileIndex, bar, bar->child_count(), "Seattle Bubble",

GURL("http://seattlebubble.com"));

- ASSERT_TRUE(bubble != NULL);

+ ASSERT_TRUE(bubble != nullptr);

const BookmarkNode* wired = AddURL(

kSingleProfileIndex, bar, 2, "Wired News", GURL("http://www.wired.com"));

const BookmarkNode* tier2_b = AddFolder(