Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2461303003: [GeometryInterface] parameter of translate*() was changed. (Closed)

Created:
4 years, 1 month ago by Hwanseung Lee
Modified:
4 years, 1 month ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Hwanseung Lee(hs1217.lee), rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GeometryInterface] parameter of translate*() was changed. first and second parameter should be default parameter. if it is missing, that value should be zero. spec list: https://drafts.fxtf.org/geometry/#ref-for-dom-dommatrixreadonly-translate-1 https://drafts.fxtf.org/geometry/#ref-for-dom-dommatrix-translateself-1 BUG=388780, 660823 Committed: https://crrev.com/c65c410f81061e8b6b2340bd82547206939ea746 Cr-Commit-Position: refs/heads/master@{#430569}

Patch Set 1 #

Patch Set 2 : add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-translate.html View 1 2 chunks +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrix.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/DOMMatrixReadOnly.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Hwanseung Lee
@dominicc, @zino PTAL, thank you.
4 years, 1 month ago (2016-10-31 13:55:54 UTC) #4
Hwanseung Lee
4 years, 1 month ago (2016-10-31 13:56:10 UTC) #5
Hwanseung Lee
@diminicc PTAL, thank you.
4 years, 1 month ago (2016-11-08 08:43:13 UTC) #16
dominicc (has gone to gerrit)
lgtm
4 years, 1 month ago (2016-11-08 08:49:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2461303003/20001
4 years, 1 month ago (2016-11-08 08:50:08 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 10:37:47 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 10:39:18 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c65c410f81061e8b6b2340bd82547206939ea746
Cr-Commit-Position: refs/heads/master@{#430569}

Powered by Google App Engine
This is Rietveld 408576698