Revert of Trigger Dangerous indicator for unsafe subresources

Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4 id:60001 of https://codereview.chromium.org/2444383007/ )

Reason for revert:
Breaks MSan tests:

First breaking build:
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tests/builds/2755

Original issue's description:
> Trigger Dangerous indicator for unsafe subresources
>
> Previously, the Dangerous indicator was not firing for subresources
> flagged by Safe Browsing as unsafe. This is because marking a
> subresource as unsafe was not triggering an omnibox update. We want to
> trigger an omnibox update whenever a URL is marked as
> whitelisted (either pending, meaning that an interstitial is showing, or
> whitelisted, meaning that an interstitial has been clicked through) in
> SafeBrowsingUIManager.
>
> To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> DidChangeVisibleSecurityState() (since it's no longer just SSL
> information that can affect the omnibox security UI) and moves it to
> WebContents so that it can be called from SafeBrowsingUIManager.
>
> BUG=659713
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> Cr-Commit-Position: refs/heads/master@{#428223}

TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659713
Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
Cr-Commit-Position: refs/heads/master@{#428520}

[tommycli, 2016-10-28 22:21:15]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-10-28 22:21:16]

Created Revert of Trigger Dangerous indicator for unsafe subresources

[commit-bot: I haz the power, 2016-10-28 22:21:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 22:22:55]

Description was changed from

==========
Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4
id:60001 of https://codereview.chromium.org/2444383007/ )

Reason for revert:
Breaks MSan tests:

First breaking build:
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...

Original issue's description:
> Trigger Dangerous indicator for unsafe subresources
> 
> Previously, the Dangerous indicator was not firing for subresources
> flagged by Safe Browsing as unsafe. This is because marking a
> subresource as unsafe was not triggering an omnibox update. We want to
> trigger an omnibox update whenever a URL is marked as
> whitelisted (either pending, meaning that an interstitial is showing, or
> whitelisted, meaning that an interstitial has been clicked through) in
> SafeBrowsingUIManager.
> 
> To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> DidChangeVisibleSecurityState() (since it's no longer just SSL
> information that can affect the omnibox security UI) and moves it to
> WebContents so that it can be called from SafeBrowsingUIManager.
> 
> BUG=659713
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> Cr-Commit-Position: refs/heads/master@{#428223}

TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659713
==========

to

==========
Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4
id:60001 of https://codereview.chromium.org/2444383007/ )

Reason for revert:
Breaks MSan tests:

First breaking build:
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...

Original issue's description:
> Trigger Dangerous indicator for unsafe subresources
> 
> Previously, the Dangerous indicator was not firing for subresources
> flagged by Safe Browsing as unsafe. This is because marking a
> subresource as unsafe was not triggering an omnibox update. We want to
> trigger an omnibox update whenever a URL is marked as
> whitelisted (either pending, meaning that an interstitial is showing, or
> whitelisted, meaning that an interstitial has been clicked through) in
> SafeBrowsingUIManager.
> 
> To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> DidChangeVisibleSecurityState() (since it's no longer just SSL
> information that can affect the omnibox security UI) and moves it to
> WebContents so that it can be called from SafeBrowsingUIManager.
> 
> BUG=659713
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> Cr-Commit-Position: refs/heads/master@{#428223}

TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659713
==========

[commit-bot: I haz the power, 2016-10-28 22:22:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-28 22:25:26]

Description was changed from

==========
Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4
id:60001 of https://codereview.chromium.org/2444383007/ )

Reason for revert:
Breaks MSan tests:

First breaking build:
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...

Original issue's description:
> Trigger Dangerous indicator for unsafe subresources
> 
> Previously, the Dangerous indicator was not firing for subresources
> flagged by Safe Browsing as unsafe. This is because marking a
> subresource as unsafe was not triggering an omnibox update. We want to
> trigger an omnibox update whenever a URL is marked as
> whitelisted (either pending, meaning that an interstitial is showing, or
> whitelisted, meaning that an interstitial has been clicked through) in
> SafeBrowsingUIManager.
> 
> To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> DidChangeVisibleSecurityState() (since it's no longer just SSL
> information that can affect the omnibox security UI) and moves it to
> WebContents so that it can be called from SafeBrowsingUIManager.
> 
> BUG=659713
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> Cr-Commit-Position: refs/heads/master@{#428223}

TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659713
==========

to

==========
Revert of Trigger Dangerous indicator for unsafe subresources (patchset #4
id:60001 of https://codereview.chromium.org/2444383007/ )

Reason for revert:
Breaks MSan tests:

First breaking build:
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...

Original issue's description:
> Trigger Dangerous indicator for unsafe subresources
>
> Previously, the Dangerous indicator was not firing for subresources
> flagged by Safe Browsing as unsafe. This is because marking a
> subresource as unsafe was not triggering an omnibox update. We want to
> trigger an omnibox update whenever a URL is marked as
> whitelisted (either pending, meaning that an interstitial is showing, or
> whitelisted, meaning that an interstitial has been clicked through) in
> SafeBrowsingUIManager.
>
> To do so, this CL renames WebContentsImpl::DidChangeVisibleSSLState() to
> DidChangeVisibleSecurityState() (since it's no longer just SSL
> information that can affect the omnibox security UI) and moves it to
> WebContents so that it can be called from SafeBrowsingUIManager.
>
> BUG=659713
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/8bb181295c47ba4d74a626f809a1a27423544f2f
> Cr-Commit-Position: refs/heads/master@{#428223}

TBR=nparker@chromium.org,jam@chromium.org,estark@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659713

Committed: https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
Cr-Commit-Position: refs/heads/master@{#428520}
==========

[commit-bot: I haz the power, 2016-10-28 22:25:27]

Patchset 1 (id:??) landed as
https://crrev.com/201e61b48c2f4ee497ca1fc09217ad8a190b829b
Cr-Commit-Position: refs/heads/master@{#428520}

[estark, 2016-10-28 22:29:33]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2456383003/ by estark@chromium.org.

The reason for reverting is: Relanding: fixed uninitialized
UnsafeResource::is_subframe.

[DaleCurtis, 2016-10-28 23:01:01]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2454393003/ by dalecurtis@chromium.org.

The reason for reverting is: Broke build,
https://build.chromium.org/p/chromium.linux/builders/Android%20Clang%20Builde....

[findit-for-me, 2016-10-28 23:26:38]

FYI: Findit identified this CL at revision 428520 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...