 Chromium Code Reviews
 Chromium Code Reviews Issue 2461073002:
  Use MediaCodec.setOutputSurface() for fullscreen transitions on M.  (Closed)
    
  
    Issue 2461073002:
  Use MediaCodec.setOutputSurface() for fullscreen transitions on M.  (Closed) 
  | Index: media/gpu/avda_codec_image.cc | 
| diff --git a/media/gpu/avda_codec_image.cc b/media/gpu/avda_codec_image.cc | 
| index 15b32d9acfaa3903dc3f22a2acbbec16c6f9cf68..c341ab40dc1619da885da2c3e1ab257acb9cdd55 100644 | 
| --- a/media/gpu/avda_codec_image.cc | 
| +++ b/media/gpu/avda_codec_image.cc | 
| @@ -26,7 +26,7 @@ AVDACodecImage::AVDACodecImage( | 
| codec_buffer_index_(kInvalidCodecBufferIndex), | 
| media_codec_(codec), | 
| decoder_(decoder), | 
| - has_surface_texture_(!!shared_state_->surface_texture_service_id()), | 
| + has_surface_texture_(false), | 
| texture_(0) {} | 
| AVDACodecImage::~AVDACodecImage() {} | 
| @@ -132,6 +132,22 @@ void AVDACodecImage::CodecChanged(MediaCodecBridge* codec) { | 
| codec_buffer_index_ = kInvalidCodecBufferIndex; | 
| } | 
| +void AVDACodecImage::SetBufferMetadata(int buffer_index, | 
| + bool has_surface_texture, | 
| + const gfx::Size& size) { | 
| + has_surface_texture_ = has_surface_texture; | 
| + codec_buffer_index_ = buffer_index; | 
| + size_ = size; | 
| +} | 
| + | 
| +bool AVDACodecImage::SetSharedState( | 
| + const scoped_refptr<AVDASharedState>& shared_state) { | 
| 
dcheng
2016/11/09 18:16:29
Nit: it's preferred to pass by value and std::move
 
DaleCurtis
2016/11/09 21:58:17
Done.
 | 
| + if (shared_state == shared_state_) | 
| + return false; | 
| + shared_state_ = shared_state; | 
| + return true; | 
| +} | 
| + | 
| void AVDACodecImage::UpdateSurfaceInternal( | 
| UpdateMode update_mode, | 
| RestoreBindingsMode attached_bindings_mode) { |