Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: content/browser/media/android/browser_surface_view_manager.cc

Issue 2461073002: Use MediaCodec.setOutputSurface() for fullscreen transitions on M. (Closed)
Patch Set: Simplify APIs. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/browser_surface_view_manager.cc
diff --git a/content/browser/media/android/browser_surface_view_manager.cc b/content/browser/media/android/browser_surface_view_manager.cc
index 00c51fe1590559dc2a266d69fd6ee75c2b40c573..1a364a4e928d8bbe4cda7969e02210e72b85d058 100644
--- a/content/browser/media/android/browser_surface_view_manager.cc
+++ b/content/browser/media/android/browser_surface_view_manager.cc
@@ -107,9 +107,12 @@ bool BrowserSurfaceViewManager::SendSurfaceID(int surface_id) {
void BrowserSurfaceViewManager::SendDestroyingVideoSurfaceIfRequired(
int surface_id) {
// Only send the surface destruction message on JB, where not doing it can
- // cause a crash.
- if (base::android::BuildInfo::GetInstance()->sdk_int() >= 18)
+ // cause a crash, and on Marshmallow+ where we can use this signal to perform
+ // a smoother full screen transition.
+ if (base::android::BuildInfo::GetInstance()->sdk_int() >= 18 &&
+ base::android::BuildInfo::GetInstance()->sdk_int() < 23) {
watk 2016/11/03 20:26:34 We might want to just do this always now. I restri
DaleCurtis 2016/11/04 01:07:22 Probably you can use crash/blame with the file pat
return;
+ }
base::WaitableEvent waiter(base::WaitableEvent::ResetPolicy::AUTOMATIC,
base::WaitableEvent::InitialState::NOT_SIGNALED);

Powered by Google App Engine
This is Rietveld 408576698