Use MediaCodec.setOutputSurface() for fullscreen transitions on M.

content/browser/media/android/browser_surface_view_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/media/android/browser_surface_view_manager.h"
 
 #include "base/android/build_info.h"
 #include "base/trace_event/trace_event.h"
 #include "content/browser/android/content_view_core_impl.h"
 #include "content/browser/gpu/gpu_process_host.h"
@@ skipping 89 matching lines @@
 
 bool BrowserSurfaceViewManager::SendSurfaceID(int surface_id) {
   return render_frame_host_->Send(
       new SurfaceViewManagerMsg_FullscreenSurfaceCreated(
           render_frame_host_->GetRoutingID(), surface_id));
 }
 
 void BrowserSurfaceViewManager::SendDestroyingVideoSurfaceIfRequired(
     int surface_id) {
   // Only send the surface destruction message on JB, where not doing it can
-  // cause a crash.
-  if (base::android::BuildInfo::GetInstance()->sdk_int() >= 18)
+  // cause a crash, and on Marshmallow+ where we can use this signal to perform
+  // a smoother full screen transition.
+  if (base::android::BuildInfo::GetInstance()->sdk_int() >= 18 &&
+      base::android::BuildInfo::GetInstance()->sdk_int() < 23) {

[watk, 2016/11/03 20:26:34]

We might want to just do this always now. I restricted it initially to see if it
caused crashes. But if it's enabled for a decent % of devices I reckon we should
enable it for all devices because it will let us remove the deferred error logic
we have in AVDA.

Actually, do you know where we can find ANR rates to check how this is going on
JB? I assume that's how deadlocks would manifest. Other kinds of failures should
result in crash reports at least.

[DaleCurtis, 2016/11/04 01:07:22]

Probably you can use crash/blame with the file path to this point and see what
pops up. I can poke around tomorrow.

     return;
+  }
 
   base::WaitableEvent waiter(base::WaitableEvent::ResetPolicy::AUTOMATIC,
                              base::WaitableEvent::InitialState::NOT_SIGNALED);
   // Unretained is okay because we're waiting on the callback.
   if (BrowserThread::PostTask(
           BrowserThread::IO, FROM_HERE,
           base::Bind(&SendDestroyingVideoSurfaceOnIO, surface_id,
                      base::Bind(&base::WaitableEvent::Signal,
                                 base::Unretained(&waiter))))) {
     base::ThreadRestrictions::ScopedAllowWait allow_wait;
     waiter.Wait();
   }
 }
 
 }  // namespace content