[recipe_modules/test_results] Refactor the logic of generating full json results files

[recipe_modules/test_results] Refactor the logic of 
generating full json results files to a single method

The motivation is we will add logic to not generate full 
json results files if the json already has full JSON 
results format.

This CL is a pure refactoring CL, there is no intended 
behavior change.

BUG=649762
Committed: https://chromium.googlesource.com/chromium/tools/build/+/0f5673778f3f8aa418d5ba97153ba7499ab4ad42

[nednguyen, 2016-10-28 17:41:22]

Description was changed from

==========
[recipe_modules/test_results] Refactor the logic of generating full json results
files

The motivation is we will add logic to not generate full json results
files if the json already has full JSON results format.

BUG=649762
==========

to

==========
[recipe_modules/test_results] Refactor the logic of generating full json results
files to a single method

The motivation is we will add logic to not generate full json results
files if the json already has full JSON results format.

This CL is a pure refactoring CL, there is no intended 
behavior change.

BUG=649762
==========

[nednguyen, 2016-10-28 17:41:22]

nednguyen@google.com changed reviewers:
+ estaab@chromium.org, kbr@chromium.org, phajdan.jr@chromium.org

[nednguyen, 2016-10-28 17:41:37]

Description was changed from

==========
[recipe_modules/test_results] Refactor the logic of generating full json results
files to a single method

The motivation is we will add logic to not generate full json results
files if the json already has full JSON results format.

This CL is a pure refactoring CL, there is no intended 
behavior change.

BUG=649762
==========

to

==========
[recipe_modules/test_results] Refactor the logic of 
generating full json results files to a single method

The motivation is we will add logic to not generate full 
json results files if the json already has full JSON 
results format.

This CL is a pure refactoring CL, there is no intended 
behavior change.

BUG=649762
==========

[Ken Russell (switch to Gerrit), 2016-10-28 18:05:25]

LGTM but I'm not an owner.

Has this change been tested? Are these entry points used outside this script
somehow?

[nednguyen, 2016-10-29 02:32:15]

On 2016/10/28 18:05:25, Ken Russell wrote:
> LGTM but I'm not an owner.
> 
> Has this change been tested? Are these entry points used outside this script
> somehow?

We have test coverage in
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/test_resu...

[Paweł Hajdan Jr., 2016-10-31 07:46:51]

LGTM

[nednguyen, 2016-10-31 10:24:42]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2016-10-31 10:24:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 10:34:13]

Description was changed from

==========
[recipe_modules/test_results] Refactor the logic of 
generating full json results files to a single method

The motivation is we will add logic to not generate full 
json results files if the json already has full JSON 
results format.

This CL is a pure refactoring CL, there is no intended 
behavior change.

BUG=649762
==========

to

==========
[recipe_modules/test_results] Refactor the logic of 
generating full json results files to a single method

The motivation is we will add logic to not generate full 
json results files if the json already has full JSON 
results format.

This CL is a pure refactoring CL, there is no intended 
behavior change.

BUG=649762

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/0f5673778f3f8aa418d5...
==========

[commit-bot: I haz the power, 2016-10-31 10:34:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/0f5673778f3f8aa418d5...

[jbudorick, 2016-10-31 17:22:28]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2464843003/ by jbudorick@chromium.org.

The reason for reverting is: breaks result generation:


Traceback (most recent call last):
  File
"/b/rr/tmppE_6sh/rw/checkout/infra/.recipe_deps/build/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py",
line 156, in <module>
    sys.exit(main())
  File
"/b/rr/tmppE_6sh/rw/checkout/infra/.recipe_deps/build/scripts/slave/recipe_modules/test_results/resources/upload_test_results.py",
line 138, in main
    master_name=options.master_name)
TypeError: generate_json_results_file() got an unexpected keyword argument
'builder_number'

e.g. from
https://build.chromium.org/p/chromium.android/builders/Lollipop%20Low-end%20T....