Lower ES3 capable requirement to GL 3.3 with extensions.

Lower ES3 capable requirement to GL 3.3 with extensions.

Still, we don't want to support ES3 on Mac if it's only 3.3.
We use blacklist to disable it.

This CL also implemented blacklist feature WebGL2.

BUG=295792
TEST=webgl2_conformance
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/05f50f9bb7f2756bc7f291df332c997476a03043
Cr-Commit-Position: refs/heads/master@{#428564}

[Zhenyao Mo, 2016-10-28 17:28:09]

Description was changed from

==========
Lower ES3 capable requirement to GL 3.3 with extensions.

Still, we don't want to support ES3 on Mac if it's only 3.3.
We use blacklist to disable it.

This CL also implemented blacklist feature WebGL2.

BUG=295792
TEST=webgl2_conformance
R=kbr@chromium.org
==========

to

==========
Lower ES3 capable requirement to GL 3.3 with extensions.

Still, we don't want to support ES3 on Mac if it's only 3.3.
We use blacklist to disable it.

This CL also implemented blacklist feature WebGL2.

BUG=295792
TEST=webgl2_conformance
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-10-28 18:55:27]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-10-28 18:56:02]

kbr: please review.
Others: FYI

[commit-bot: I haz the power, 2016-10-28 18:56:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-28 19:00:06]

https://codereview.chromium.org/2460943002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_impl.cc (left):

https://codereview.chromium.org/2460943002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_process_host_impl.cc:1690:
switches::kEnableUnsafeES3APIs,
This is no longer necessary. We just fail the context creation request at GPU
process side.

https://codereview.chromium.org/2460943002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gpu_preferences.h (left):

https://codereview.chromium.org/2460943002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gpu_preferences.h:135: bool enable_unsafe_es3_apis =
false;
Remove this because it's not used at all.

[Ken Russell (switch to Gerrit), 2016-10-28 19:11:30]

Very good. LGTM

[Zhenyao Mo, 2016-10-28 19:21:49]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 19:21:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-28 19:34:05]

zmo@chromium.org changed reviewers:
+ dcheng@chromium.org, jschuh@chromium.org, piman@chromium.org

[Zhenyao Mo, 2016-10-28 19:34:05]

piman: content/ OWNER review

[Zhenyao Mo, 2016-10-28 19:35:03]

dcheng/jschuh: content/common/gpu_host_messages.h

[piman, 2016-10-28 20:01:21]

Do we have a specific driver we tried this on that only has 3.3?

https://codereview.chromium.org/2460943002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gpu_preferences.h (left):

https://codereview.chromium.org/2460943002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gpu_preferences.h:135: bool enable_unsafe_es3_apis =
false;
Mmh, the goal of GpuPreferences is to avoid passing command-line flags, because
it doesn't work well with Mus, it duplicates logic everywhere, and it can cause
inconsistencies in single-process mode.

I realize that this is not wired on the service side currently, but we really
ought to fix it instead of removing it - it really just boils down to passing
the GpuPreferences to the FeatureInfo constructor in
GpuCommandBufferStub::Initialize.

https://codereview.chromium.org/2460943002/diff/40001/ui/gl/gl_version_info.cc
File ui/gl/gl_version_info.cc (right):

https://codereview.chromium.org/2460943002/diff/40001/ui/gl/gl_version_info.c...
ui/gl/gl_version_info.cc:96: (IsAtLeastGL(4, 2) ||
has_extension("GL_ARB_texture_storage"));
nit: you can skip IsAtLeastGL(4, 2), since it's always false if we get here (see
l.82-83).

[commit-bot: I haz the power, 2016-10-28 20:11:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 20:11:16]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Zhenyao Mo, 2016-10-28 23:22:12]

Done.  Intel folks tested extensively with Mesa 3.3 on Intel GPU and they work
fine with WebGL2.  Per their request, we add back support WebGL2 on 3.3.

https://codereview.chromium.org/2460943002/diff/40001/ui/gl/gl_version_info.cc
File ui/gl/gl_version_info.cc (right):

https://codereview.chromium.org/2460943002/diff/40001/ui/gl/gl_version_info.c...
ui/gl/gl_version_info.cc:96: (IsAtLeastGL(4, 2) ||
has_extension("GL_ARB_texture_storage"));
On 2016/10/28 20:01:21, piman wrote:
> nit: you can skip IsAtLeastGL(4, 2), since it's always false if we get here
(see
> l.82-83).

Done.

[Zhenyao Mo, 2016-10-28 23:22:20]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 23:22:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-10-28 23:23:28]

zmo@chromium.org changed reviewers:
- dcheng@chromium.org, jschuh@chromium.org

[Zhenyao Mo, 2016-10-28 23:23:28]

-dcheng, jschuh (the affected files are removed)

[piman, 2016-10-28 23:27:36]

lgtm

[commit-bot: I haz the power, 2016-10-29 00:31:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-29 00:31:16]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-10-29 00:34:29]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-10-29 00:34:30]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2460943002/#ps30018
(title: "address piman comment")

[commit-bot: I haz the power, 2016-10-29 00:35:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-29 00:40:52]

Committed patchset #4 (id:30018)

[commit-bot: I haz the power, 2016-10-29 00:47:08]

Description was changed from

==========
Lower ES3 capable requirement to GL 3.3 with extensions.

Still, we don't want to support ES3 on Mac if it's only 3.3.
We use blacklist to disable it.

This CL also implemented blacklist feature WebGL2.

BUG=295792
TEST=webgl2_conformance
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Lower ES3 capable requirement to GL 3.3 with extensions.

Still, we don't want to support ES3 on Mac if it's only 3.3.
We use blacklist to disable it.

This CL also implemented blacklist feature WebGL2.

BUG=295792
TEST=webgl2_conformance
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/05f50f9bb7f2756bc7f291df332c997476a03043
Cr-Commit-Position: refs/heads/master@{#428564}
==========

[commit-bot: I haz the power, 2016-10-29 00:47:09]

Patchset 4 (id:??) landed as
https://crrev.com/05f50f9bb7f2756bc7f291df332c997476a03043
Cr-Commit-Position: refs/heads/master@{#428564}

[Yang Gu, 2016-10-30 15:46:23]

Thank you very much for this CL! It saves many Linux desktops with Intel Mesa
driver to support WebGL 2.