Issue 246078: Revert my attempt at cleaning up RenderViewHost::UnhandledKeyboardEvent in my...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246078: Revert my attempt at cleaning up RenderViewHost::UnhandledKeyboardEvent in my... (Closed)

Created:
11 years, 2 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Craig

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert my attempt at cleaning up RenderViewHost::UnhandledKeyboardEvent in my previous patch. Looks like the check is needed because otherwise KeyUp triggers the accelerator a second time. BUG=23260 TBR=craig.schlenter Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27852

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	chrome/browser/renderer_host/render_view_host.cc	View		1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Craig

11 years, 2 months ago (2009-10-02 17:35:28 UTC) #2

I have tested this briefly and this works for me but I am clueless about the
code in question. So a tentative LGTM on the basis that it is restoring
something that was there originally and seems to work :)

Thanks for looking into this!

Expand Messages | Collapse Messages