Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: chrome/browser/renderer_host/render_view_host.cc

Issue 246078: Revert my attempt at cleaning up RenderViewHost::UnhandledKeyboardEvent in my... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_view_host.cc
===================================================================
--- chrome/browser/renderer_host/render_view_host.cc (revision 27822)
+++ chrome/browser/renderer_host/render_view_host.cc (working copy)
@@ -1435,8 +1435,16 @@
void RenderViewHost::UnhandledKeyboardEvent(
const NativeWebKeyboardEvent& event) {
RenderViewHostDelegate::View* view = delegate_->GetViewDelegate();
- if (view)
- view->HandleKeyboardEvent(event);
+ if (view) {
+ // TODO(brettw) why do we have to filter these types of events here. Can't
+ // the renderer just send us the ones we care abount, or maybe the view
+ // should be able to decide which ones it wants or not?
+ if ((event.type == WebInputEvent::RawKeyDown) ||
+ (event.type == WebInputEvent::KeyDown) ||
+ (event.type == WebInputEvent::Char)) {
+ view->HandleKeyboardEvent(event);
+ }
+ }
}
void RenderViewHost::OnUserGesture() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698