Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issue 2460763002: Fixed track id remapping in MSE FrameProcessor (Closed)

Created:
4 years, 1 month ago by servolk
Modified:
4 years, 1 month ago
Reviewers:
chcunningham, wolenetz
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed track id remapping in MSE FrameProcessor Previously FrameProcessor couldn't handle cases where audio and video track ids were swapped between the previous and current init segment, because we tried to do an in-place update, which is impossible to do correctly when track ids have been swapped. Consider the case where in the first init segment A=1,V=2 and in the second segment A=2,V=1. In such case we can't simply move let's say track A from 1 to 2, because track id 2 is occupied by V, and vice versa. This CL implements a more advanced logic, that will record how track ids have changed between segments and will then update all track buffer mappings in FrameProcessor::UpdateTrackIds at once. BUG=660247 Committed: https://crrev.com/b9233a906062fd461503fca84fa2223ee315bfaf Cr-Commit-Position: refs/heads/master@{#428473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -27 lines) Patch
M media/filters/frame_processor.h View 2 chunks +12 lines, -8 lines 0 comments Download
M media/filters/frame_processor.cc View 1 chunk +22 lines, -9 lines 0 comments Download
M media/filters/source_buffer_state.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M media/filters/source_buffer_state_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
servolk
4 years, 1 month ago (2016-10-28 03:24:38 UTC) #5
cblume
Thank you for fixing this so quickly and staying late.
4 years, 1 month ago (2016-10-28 05:41:19 UTC) #8
servolk
On 2016/10/28 05:41:19, cblume wrote: > Thank you for fixing this so quickly and staying ...
4 years, 1 month ago (2016-10-28 18:34:06 UTC) #13
chcunningham
Nice change. LGTM
4 years, 1 month ago (2016-10-28 19:40:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460763002/1
4 years, 1 month ago (2016-10-28 20:15:12 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 20:20:58 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b9233a906062fd461503fca84fa2223ee315bfaf Cr-Commit-Position: refs/heads/master@{#428473}
4 years, 1 month ago (2016-10-28 20:24:20 UTC) #20
wolenetz
4 years, 1 month ago (2016-10-28 23:29:29 UTC) #21
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698