Fixed track id remapping in MSE FrameProcessor

media/filters/frame_processor.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/frame_processor.h"
 
 #include <stdint.h>
 
 #include <cstdlib>
 
@@ skipping 245 matching lines @@
   if (existing_track) {
     MEDIA_LOG(ERROR, media_log_) << "Failure adding track with duplicate ID "
                                  << id;
     return false;
   }
 
   track_buffers_[id] = base::MakeUnique<MseTrackBuffer>(stream);
   return true;
 }
 
-bool FrameProcessor::UpdateTrack(StreamParser::TrackId old_id,
-                                 StreamParser::TrackId new_id) {
-  DVLOG(2) << __func__ << "() : old_id=" << old_id << ", new_id=" << new_id;
+bool FrameProcessor::UpdateTrackIds(const TrackIdChanges& track_id_changes) {
+  TrackBuffersMap& old_track_buffers = track_buffers_;
+  TrackBuffersMap new_track_buffers;
 
-  if (old_id == new_id || !FindTrack(old_id) || FindTrack(new_id)) {
-    MEDIA_LOG(ERROR, media_log_) << "Failure updating track id from " << old_id
-                                 << " to " << new_id;
-    return false;
+  for (const auto& ids : track_id_changes) {
+    if (old_track_buffers.find(ids.first) == old_track_buffers.end() ||
+        new_track_buffers.find(ids.second) != new_track_buffers.end()) {
+      MEDIA_LOG(ERROR, media_log_) << "Failure updating track id from "
+                                   << ids.first << " to " << ids.second;
+      return false;
+    }
+    new_track_buffers[ids.second] = std::move(old_track_buffers[ids.first]);
+    CHECK_EQ(1u, old_track_buffers.erase(ids.first));
   }
 
-  track_buffers_[new_id] = std::move(track_buffers_[old_id]);
-  CHECK_EQ(1u, track_buffers_.erase(old_id));
+  // Process remaining track buffers with unchanged ids.
+  for (const auto& t : old_track_buffers) {
+    if (new_track_buffers.find(t.first) != new_track_buffers.end()) {
+      MEDIA_LOG(ERROR, media_log_) << "Track id " << t.first << " conflict";
+      return false;
+    }
+    new_track_buffers[t.first] = std::move(old_track_buffers[t.first]);
+  }
+
+  std::swap(track_buffers_, new_track_buffers);
   return true;
 }
 
 void FrameProcessor::SetAllTrackBuffersNeedRandomAccessPoint() {
   for (auto itr = track_buffers_.begin(); itr != track_buffers_.end(); ++itr) {
     itr->second->set_needs_random_access_point(true);
   }
 }
 
 void FrameProcessor::Reset() {
@@ skipping 450 matching lines @@
     // Step 21 is currently handled differently. See SourceBufferState's
     // |auto_update_timestamp_offset_|.
     return true;
   }
 
   NOTREACHED();
   return false;
 }
 
 }  // namespace media