Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issue 2460673002: Need to remove line pagination struts when no longer fragmented. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Need to remove line pagination struts when no longer fragmented. We only used to recalculate pagination struts on lines when we were inside a fragmentation context, but if said fragmentation context ceases to be one, we need one final strut recalculation pass, to get rid of them all. BUG=658019 Committed: https://crrev.com/e2a5a72d7a8ac8bb8016c7dbe9021849c6ca04b8 Cr-Commit-Position: refs/heads/master@{#428161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -34 lines) Patch
A + third_party/WebKit/LayoutTests/fragmentation/become-unfragmented-with-lines.html View 2 chunks +9 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 7 chunks +18 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineLayoutState.h View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-10-27 20:54:45 UTC) #3
eae
LGTM
4 years, 1 month ago (2016-10-27 22:02:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460673002/1
4 years, 1 month ago (2016-10-27 22:07:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 22:16:42 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 22:19:15 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2a5a72d7a8ac8bb8016c7dbe9021849c6ca04b8
Cr-Commit-Position: refs/heads/master@{#428161}

Powered by Google App Engine
This is Rietveld 408576698