third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp - Issue 2460673002: Need to remove line pagination struts when no longer fragmented.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 2460673002: Need to remove line pagination struts when no longer fragmented. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

index 2caf3a1a830be8de525afe158412b7c7f70151ba..48c972d368a62eb7c7d88bebf6e97382b606fdf2 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

@@ -1123,6 +1123,8 @@ void LayoutBlockFlow::adjustLinePositionForPagination(RootInlineBox& lineBox,

logicalOffset += delta;

lineBox.setPaginationStrut(LayoutUnit());

lineBox.setIsFirstAfterPageBreak(false);

+ if (!view()->layoutState()->isPaginated())

+ return;

LayoutUnit pageLogicalHeight = pageLogicalHeightForOffset(logicalOffset);

if (!pageLogicalHeight)

return;