Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issue 2460653003: Move enable_mdns build flag to net. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by brettw (busy this week)
Modified:
6 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move enable_mdns build flag to net. Moves it out of the global feature flags and into the net feature flags. Migrates the flag from a #define to a buildflag. Committed: https://crrev.com/5224a189c5968ac267a0c5456846c81495e7dfe3 Cr-Commit-Position: refs/heads/master@{#428514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_shared_client.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_notifications.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_notifications.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/features.gni View 1 chunk +1 line, -0 lines 0 comments Download
M net/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M net/features.gni View 1 chunk +3 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 12 (5 generated)
brettw (busy this week)
Easy followup on the last net flags patch.
6 months ago (2016-10-28 17:03:36 UTC) #2
davidben
lgtm
6 months ago (2016-10-28 17:07:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460653003/1
6 months ago (2016-10-28 17:25:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/252511) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
6 months ago (2016-10-28 19:27:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460653003/1
6 months ago (2016-10-28 20:59:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 months ago (2016-10-28 22:13:32 UTC) #10
commit-bot: I haz the power
6 months ago (2016-10-28 22:15:14 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5224a189c5968ac267a0c5456846c81495e7dfe3
Cr-Commit-Position: refs/heads/master@{#428514}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46