Use new LazyDataProperty API for DOM constructors

Use new LazyDataProperty API for DOM constructors

R=haraken@chromium.org
BUG=660853
Committed: https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d
Cr-Commit-Position: refs/heads/master@{#429263}

[jochen (gone - plz use gerrit), 2016-10-31 14:37:52]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 14:38:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-10-31 14:38:53]

ptal

[commit-bot: I haz the power, 2016-10-31 16:31:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 16:31:23]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-11-01 07:17:31]

haraken@chromium.org changed reviewers:
+ yukishiino@chromium.org

[haraken, 2016-11-01 07:17:31]

LGTM

I hope we can eventually generalize the API into "invalidatable, cached
data-type properties" and "invalidatable, cached accessor-type properties".

yukishiino@: Method names in V8DOMConfiguration is getting more and more
confusing. Attribute, Accessor, Property, DataAttribute etc. Would you mind
refactoring them?

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp (right):

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp:136: if
(world.isMainWorld()) {

Instead, can we add DCHECK(!attribute.getterForMainWorld)? I don't really want
to support per-world bindings (which should be deprecated in favor of a saner
optimization like cacheable attributes) in new features.

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h (right):

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h:105: static void
installLazyDataAttributes(

Add a comment about what the lazy data attribute means.

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/scripts/v8_attributes.py (right):

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/scripts/v8_attributes.py:213: def
filter_has_some_attribute_configuration(attributes):

has_data_attribute_configuration

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/scripts/v8_attributes.py:251:
'has_lazy_data_configuration': filter_has_lazy_data_configuration,

has_lazy_data_attribute_configuration

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
(right):

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl:242: const
V8DOMConfiguration::AttributeConfiguration {{v8_class}}LazyAttributes[] = {

LazyDataAttributes

[Yuki, 2016-11-01 13:25:16]

I see a lot of confusion of wording (e.g. constructors are NOT attributes).  I'm
happy to refactor it after this CL lands.

LGTM.

[jochen (gone - plz use gerrit), 2016-11-02 11:57:01]

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp (right):

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp:136: if
(world.isMainWorld()) {
On 2016/11/01 at 07:17:31, haraken wrote:
> Instead, can we add DCHECK(!attribute.getterForMainWorld)? I don't really want
to support per-world bindings (which should be deprecated in favor of a saner
optimization like cacheable attributes) in new features.

done

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h (right):

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h:105: static void
installLazyDataAttributes(
On 2016/11/01 at 07:17:31, haraken wrote:
> Add a comment about what the lazy data attribute means.

done

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/scripts/v8_attributes.py (right):

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/scripts/v8_attributes.py:213: def
filter_has_some_attribute_configuration(attributes):
On 2016/11/01 at 07:17:31, haraken wrote:
> has_data_attribute_configuration

done

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/scripts/v8_attributes.py:251:
'has_lazy_data_configuration': filter_has_lazy_data_configuration,
On 2016/11/01 at 07:17:31, haraken wrote:
> has_lazy_data_attribute_configuration

done

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
(right):

https://codereview.chromium.org/2460423002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl:242: const
V8DOMConfiguration::AttributeConfiguration {{v8_class}}LazyAttributes[] = {
On 2016/11/01 at 07:17:31, haraken wrote:
> LazyDataAttributes

done

[jochen (gone - plz use gerrit), 2016-11-02 12:01:57]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 12:02:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-11-02 12:02:05]

The CQ bit was unchecked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-11-02 12:02:08]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-11-02 12:02:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/2460423002/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2016-11-02 12:02:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 13:27:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-02 13:29:14]

Description was changed from

==========
Use new LazyDataProperty API for DOM constructors

R=haraken@chromium.org
BUG=660853
==========

to

==========
Use new LazyDataProperty API for DOM constructors

R=haraken@chromium.org
BUG=660853

Committed: https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d
Cr-Commit-Position: refs/heads/master@{#429263}
==========

[commit-bot: I haz the power, 2016-11-02 13:29:15]

Patchset 2 (id:??) landed as
https://crrev.com/4be3afec3ef1423f80dcfa0a50e9b68f6bc5062d
Cr-Commit-Position: refs/heads/master@{#429263}