Use new LazyDataProperty API for DOM constructors

third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 101 matching lines @@
   if (attribute.propertyLocationConfiguration & V8DOMConfiguration::OnPrototype)
     prototype
         ->DefineOwnProperty(
             isolate->GetCurrentContext(), name, data,
             static_cast<v8::PropertyAttribute>(attribute.attribute))
         .ToChecked();
   if (attribute.propertyLocationConfiguration & V8DOMConfiguration::OnInterface)
     NOTREACHED();
 }
 
+void installLazyDataAttributeInternal(
+    v8::Isolate* isolate,
+    v8::Local<v8::ObjectTemplate> instanceTemplate,
+    v8::Local<v8::ObjectTemplate> prototypeTemplate,
+    const V8DOMConfiguration::AttributeConfiguration& attribute,
+    const DOMWrapperWorld& world) {
+  if (attribute.exposeConfiguration ==
+          V8DOMConfiguration::OnlyExposedToPrivateScript &&
+      !world.isPrivateScriptIsolatedWorld())
+    return;
+
+  v8::Local<v8::Name> name = v8AtomicString(isolate, attribute.name);
+  v8::AccessorNameGetterCallback getter = attribute.getter;
+  DCHECK(!attribute.setter);
+  if (world.isMainWorld()) {

[haraken, 2016/11/01 07:17:31]

Instead, can we add DCHECK(!attribute.getterForMainWorld)? I don't really want
to support per-world bindings (which should be deprecated in favor of a saner
optimization like cacheable attributes) in new features.

[jochen (gone - plz use gerrit), 2016/11/02 11:57:00]

done

+    if (attribute.getterForMainWorld)
+      getter = attribute.getterForMainWorld;
+    DCHECK(!attribute.setterForMainWorld);
+  }
+  v8::Local<v8::Value> data =
+      v8::External::New(isolate, const_cast<WrapperTypeInfo*>(attribute.data));
+  DCHECK(static_cast<v8::AccessControl>(attribute.settings) == v8::DEFAULT);
+
+  DCHECK(attribute.propertyLocationConfiguration);
+  if (attribute.propertyLocationConfiguration &
+      V8DOMConfiguration::OnInstance) {
+    instanceTemplate->SetLazyDataProperty(
+        name, getter, data,
+        static_cast<v8::PropertyAttribute>(attribute.attribute));
+  }
+  if (attribute.propertyLocationConfiguration &
+      V8DOMConfiguration::OnPrototype) {
+    prototypeTemplate->SetLazyDataProperty(
+        name, getter, data,
+        static_cast<v8::PropertyAttribute>(attribute.attribute));
+  }
+  if (attribute.propertyLocationConfiguration & V8DOMConfiguration::OnInterface)
+    NOTREACHED();
+}
+
 template <class FunctionOrTemplate>
 v8::Local<FunctionOrTemplate> createAccessorFunctionOrTemplate(
     v8::Isolate*,
     v8::FunctionCallback,
     v8::Local<v8::Value> data,
     v8::Local<v8::Signature>,
     int length);
 
 template <>
 v8::Local<v8::FunctionTemplate>
@@ skipping 284 matching lines @@
 
 void V8DOMConfiguration::installAttribute(
     v8::Isolate* isolate,
     const DOMWrapperWorld& world,
     v8::Local<v8::Object> instance,
     v8::Local<v8::Object> prototype,
     const AttributeConfiguration& attribute) {
   installAttributeInternal(isolate, instance, prototype, attribute, world);
 }
 
+void V8DOMConfiguration::installLazyDataAttributes(
+    v8::Isolate* isolate,
+    const DOMWrapperWorld& world,
+    v8::Local<v8::ObjectTemplate> instanceTemplate,
+    v8::Local<v8::ObjectTemplate> prototypeTemplate,
+    const AttributeConfiguration* attributes,
+    size_t attributeCount) {
+  for (size_t i = 0; i < attributeCount; ++i) {
+    installLazyDataAttributeInternal(isolate, instanceTemplate,
+                                     prototypeTemplate, attributes[i], world);
+  }
+}
+
 void V8DOMConfiguration::installAccessors(
     v8::Isolate* isolate,
     const DOMWrapperWorld& world,
     v8::Local<v8::ObjectTemplate> instanceTemplate,
     v8::Local<v8::ObjectTemplate> prototypeTemplate,
     v8::Local<v8::FunctionTemplate> interfaceTemplate,
     v8::Local<v8::Signature> signature,
     const AccessorConfiguration* accessors,
     size_t accessorCount) {
   for (size_t i = 0; i < accessorCount; ++i)
@@ skipping 166 matching lines @@
 void V8DOMConfiguration::setClassString(
     v8::Isolate* isolate,
     v8::Local<v8::ObjectTemplate> objectTemplate,
     const char* classString) {
   objectTemplate->Set(
       v8::Symbol::GetToStringTag(isolate), v8AtomicString(isolate, classString),
       static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontEnum));
 }
 
 }  // namespace blink