Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2460353002: [modules] Make ModuleInfoEntry a Struct rather than FixedArray. (Closed)

Created:
4 years, 1 month ago by neis
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Make ModuleInfoEntry a Struct rather than FixedArray. It always has the same number of slots. R=adamk@chromium.org TBR=bmeurer@chromium.org BUG=v8:1569 Committed: https://crrev.com/43995e2fa876c9501f7eb9440d33999708f1428b Cr-Commit-Position: refs/heads/master@{#40754}

Patch Set 1 #

Total comments: 9

Patch Set 2 : Address review comments. #

Patch Set 3 : Rebase. #

Patch Set 4 : Remove extra semicolons after macro use. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -112 lines) Patch
M include/v8.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast/ast-types.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/scopeinfo.cc View 1 2 1 chunk +9 lines, -8 lines 0 comments Download
M src/compiler/types.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/factory.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/heap.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.h View 1 2 3 8 chunks +71 lines, -67 lines 0 comments Download
M src/objects-debug.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download
M src/objects-inl.h View 3 chunks +7 lines, -26 lines 0 comments Download
M src/objects-printer.cc View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 27 (14 generated)
neis
4 years, 1 month ago (2016-10-31 12:02:28 UTC) #1
adamk
lgtm % heap verification and a few nits in objects.h https://codereview.chromium.org/2460353002/diff/1/src/objects-debug.cc File src/objects-debug.cc (right): https://codereview.chromium.org/2460353002/diff/1/src/objects-debug.cc#newcode1003 ...
4 years, 1 month ago (2016-10-31 18:14:36 UTC) #2
adamk
https://codereview.chromium.org/2460353002/diff/1/src/objects.h File src/objects.h (right): https://codereview.chromium.org/2460353002/diff/1/src/objects.h#newcode8090 src/objects.h:8090: }; On 2016/10/31 18:14:36, adamk wrote: > Please add ...
4 years, 1 month ago (2016-10-31 20:15:19 UTC) #3
neis
https://codereview.chromium.org/2460353002/diff/1/src/objects-debug.cc File src/objects-debug.cc (right): https://codereview.chromium.org/2460353002/diff/1/src/objects-debug.cc#newcode1003 src/objects-debug.cc:1003: void ModuleInfoEntry::ModuleInfoEntryVerify() { CHECK(IsModuleInfoEntry()); } On 2016/10/31 18:14:36, adamk ...
4 years, 1 month ago (2016-11-02 09:59:57 UTC) #4
adamk
still lgtm
4 years, 1 month ago (2016-11-02 18:38:24 UTC) #5
Hannes Payer (out of office)
heap lgtm
4 years, 1 month ago (2016-11-03 10:05:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460353002/40001
4 years, 1 month ago (2016-11-04 08:53:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/27831)
4 years, 1 month ago (2016-11-04 08:56:50 UTC) #12
neis
+bmeurer for compiler
4 years, 1 month ago (2016-11-04 08:59:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460353002/60001
4 years, 1 month ago (2016-11-04 09:35:26 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-04 09:37:29 UTC) #24
Benedikt Meurer
LGTM
4 years, 1 month ago (2016-11-04 16:51:06 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:22:15 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/43995e2fa876c9501f7eb9440d33999708f1428b
Cr-Commit-Position: refs/heads/master@{#40754}

Powered by Google App Engine
This is Rietveld 408576698