Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2460233003: [modules] Assign cell indices at validation time. (Closed)

Created:
4 years, 1 month ago by neis
Modified:
4 years, 1 month ago
Reviewers:
adamk, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Assign cell indices at validation time. Instead of having a MODULE variable's index be 0 or 1, let it be the index of its cell. In this CL, we assign the indices but we continue to only use them to distinguish imports from exports. Actually using them to directly access the cells will be done in a later CL. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/1dd241c44bab3facea7abe5cb0e51e1315b376ce Cr-Commit-Position: refs/heads/master@{#40752}

Patch Set 1 #

Total comments: 18

Patch Set 2 : Add comments. #

Patch Set 3 : Address review comments. #

Total comments: 1

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -47 lines) Patch
M src/ast/modules.h View 1 2 5 chunks +18 lines, -4 lines 0 comments Download
M src/ast/modules.cc View 1 2 3 7 chunks +41 lines, -5 lines 0 comments Download
M src/ast/scopeinfo.cc View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M src/ast/scopes.cc View 1 2 3 2 chunks +18 lines, -7 lines 0 comments Download
M src/ast/variables.h View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download
M src/debug/debug-scopes.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 4 chunks +9 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 3 7 chunks +9 lines, -11 lines 0 comments Download
M src/objects-inl.h View 1 chunk +6 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (3 generated)
neis
4 years, 1 month ago (2016-10-31 11:12:02 UTC) #1
Yang
On 2016/10/31 11:12:02, neis wrote: src/debug lgtm.
4 years, 1 month ago (2016-10-31 12:57:04 UTC) #2
adamk
https://codereview.chromium.org/2460233003/diff/1/src/ast/modules.cc File src/ast/modules.cc (right): https://codereview.chromium.org/2460233003/diff/1/src/ast/modules.cc#newcode158 src/ast/modules.cc:158: for (int i = 0, length_i = data->length(); i ...
4 years, 1 month ago (2016-10-31 18:25:04 UTC) #3
neis
https://codereview.chromium.org/2460233003/diff/1/src/ast/modules.cc File src/ast/modules.cc (right): https://codereview.chromium.org/2460233003/diff/1/src/ast/modules.cc#newcode158 src/ast/modules.cc:158: for (int i = 0, length_i = data->length(); i ...
4 years, 1 month ago (2016-11-03 10:43:48 UTC) #4
neis
Update: I tried to better encapsulate the cell_index business in https://codereview.chromium.org/2465283004/.
4 years, 1 month ago (2016-11-03 12:57:13 UTC) #5
adamk
lgtm % typo https://codereview.chromium.org/2460233003/diff/40001/src/ast/modules.cc File src/ast/modules.cc (right): https://codereview.chromium.org/2460233003/diff/40001/src/ast/modules.cc#newcode213 src/ast/modules.cc:213: // This local name may be ...
4 years, 1 month ago (2016-11-03 18:10:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460233003/60001
4 years, 1 month ago (2016-11-04 08:24:10 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-11-04 08:51:22 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:22:09 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/1dd241c44bab3facea7abe5cb0e51e1315b376ce
Cr-Commit-Position: refs/heads/master@{#40752}

Powered by Google App Engine
This is Rietveld 408576698