Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2460313002: [wasm] Do not run the infinite loop test if FLAG_dump_wasm_module is true (Closed)

Created:
4 years, 1 month ago by ahaas
Modified:
4 years, 1 month ago
Reviewers:
bradnelson
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Do not run the infinite loop test if FLAG_dump_wasm_module is true By not dumping the module of the test, we avoid adding code of an infinite loop to the corpus of the wasm fuzzer. R=bradnelson@chromium.org NOTRY=true Committed: https://crrev.com/da90034e02299d99d1ec24a57ed353764356b6f8 Cr-Commit-Position: refs/heads/master@{#40680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ahaas
4 years, 1 month ago (2016-10-31 08:46:23 UTC) #1
bradnelson
lgtm
4 years, 1 month ago (2016-10-31 17:54:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460313002/1
4 years, 1 month ago (2016-10-31 17:54:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-31 17:56:05 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:18:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da90034e02299d99d1ec24a57ed353764356b6f8
Cr-Commit-Position: refs/heads/master@{#40680}

Powered by Google App Engine
This is Rietveld 408576698