Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(989)

Unified Diff: test/cctest/wasm/test-run-wasm-module.cc

Issue 2460313002: [wasm] Do not run the infinite loop test if FLAG_dump_wasm_module is true (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/wasm/test-run-wasm-module.cc
diff --git a/test/cctest/wasm/test-run-wasm-module.cc b/test/cctest/wasm/test-run-wasm-module.cc
index e059951018731a6ee108860c0c4b78ff88f12710..458fc1a9e4fd65b4b9127832e282411310870b0f 100644
--- a/test/cctest/wasm/test-run-wasm-module.cc
+++ b/test/cctest/wasm/test-run-wasm-module.cc
@@ -437,6 +437,9 @@ class InterruptThread : public v8::base::Thread {
};
TEST(TestInterruptLoop) {
+ // Do not dump the module of this test because it contains an infinite loop.
+ if (FLAG_dump_wasm_module) return;
+
// This test tests that WebAssembly loops can be interrupted, i.e. that if an
// InterruptCallback is registered by {Isolate::RequestInterrupt}, then the
// InterruptCallback is eventually called even if a loop in WebAssembly code
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698