Checking RendererThreadImpl for null when creating media player.

Checking RendererThreadImpl for null when creating media player.

Also adding CHECKs for it not being nullptr in AudioDeviceFactory.
RendererThreadImpl lives in TLS, and a call to
lazy_tls.Pointer()->Get()::GetAudioRendererMixerManager()
(
https://cs.chromium.org/chromium/src/content/renderer/media/audio_device_factory.cc?dr=CSs&q=AudioDeviceFa&sq=package:chromium&l=76
https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?q=RenderThreadImpl::current&sq=package:chromium&dr=CSs&l=1575)
end up accessing |audio_renderer_mixer_manager_| of nullptr.

BUG=657167
TESTING=running failed clusterfuzz test locally: test passes after the fix.

Committed: https://crrev.com/64b9793077e8daf693a06eab4b98dc5a6374630d
Cr-Commit-Position: refs/heads/master@{#428728}

[o1ka, 2016-10-31 14:12:06]

The CQ bit was checked by olka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 14:12:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[o1ka, 2016-10-31 14:27:18]

olka@chromium.org changed reviewers:
+ avi@chromium.org

[o1ka, 2016-10-31 14:27:19]

PTAL

[o1ka, 2016-10-31 14:28:49]

Description was changed from

==========
Checking RendererThreadImpl for null when creating media player.

Also adding CHECKs for it not being nullptr in AudioDeviceFactory.
RendererThreadImpl lives in TLS, and a call to
lazy_tls.Pointer()->Get()::GetAudioRendererMixerManager()
(
https://cs.chromium.org/chromium/src/content/renderer/media/audio_device_fact...
https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?q...)
end up accessing |audio_renderer_mixer_manager_| of nullptr.

BUG=657167
==========

to

==========
Checking RendererThreadImpl for null when creating media player.

Also adding CHECKs for it not being nullptr in AudioDeviceFactory.
RendererThreadImpl lives in TLS, and a call to
lazy_tls.Pointer()->Get()::GetAudioRendererMixerManager()
(
https://cs.chromium.org/chromium/src/content/renderer/media/audio_device_fact...
https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?q...)
end up accessing |audio_renderer_mixer_manager_| of nullptr.

BUG=657167
TESTING=running failed clusterfuzz test locally: test passes after the fix.
==========

[Avi (use Gerrit), 2016-10-31 14:45:29]

https://codereview.chromium.org/2460303003/diff/1/content/renderer/media/audi...
File content/renderer/media/audio_device_factory.cc (right):

https://codereview.chromium.org/2460303003/diff/1/content/renderer/media/audi...
content/renderer/media/audio_device_factory.cc:191: << "GetOutputDeviceInfo() is
called on a wrong thread ";
Why a CHECK here and above and not a DCHECK?

https://codereview.chromium.org/2460303003/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2460303003/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:2738: // Render thread may not exist in
tests:
Make comments be complete sentences, ending in a .

[o1ka, 2016-10-31 14:56:36]

Patchset #2 (id:20001) has been deleted

[o1ka, 2016-10-31 14:57:01]

Patchset #2 (id:40001) has been deleted

[o1ka, 2016-10-31 14:58:38]

PTAL - fixed.

https://codereview.chromium.org/2460303003/diff/1/content/renderer/media/audi...
File content/renderer/media/audio_device_factory.cc (right):

https://codereview.chromium.org/2460303003/diff/1/content/renderer/media/audi...
content/renderer/media/audio_device_factory.cc:191: << "GetOutputDeviceInfo() is
called on a wrong thread ";
On 2016/10/31 14:45:29, Avi wrote:
> Why a CHECK here and above and not a DCHECK? 

Done.

https://codereview.chromium.org/2460303003/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2460303003/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:2738: // Render thread may not exist in
tests:
On 2016/10/31 14:45:29, Avi wrote:
> Make comments be complete sentences, ending in a .

Done.

[Avi (use Gerrit), 2016-10-31 15:20:32]

lgtm

[o1ka, 2016-10-31 15:22:05]

The CQ bit was checked by olka@chromium.org

[commit-bot: I haz the power, 2016-10-31 15:22:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 16:14:29]

Description was changed from

==========
Checking RendererThreadImpl for null when creating media player.

Also adding CHECKs for it not being nullptr in AudioDeviceFactory.
RendererThreadImpl lives in TLS, and a call to
lazy_tls.Pointer()->Get()::GetAudioRendererMixerManager()
(
https://cs.chromium.org/chromium/src/content/renderer/media/audio_device_fact...
https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?q...)
end up accessing |audio_renderer_mixer_manager_| of nullptr.

BUG=657167
TESTING=running failed clusterfuzz test locally: test passes after the fix.
==========

to

==========
Checking RendererThreadImpl for null when creating media player.

Also adding CHECKs for it not being nullptr in AudioDeviceFactory.
RendererThreadImpl lives in TLS, and a call to
lazy_tls.Pointer()->Get()::GetAudioRendererMixerManager()
(
https://cs.chromium.org/chromium/src/content/renderer/media/audio_device_fact...
https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?q...)
end up accessing |audio_renderer_mixer_manager_| of nullptr.

BUG=657167
TESTING=running failed clusterfuzz test locally: test passes after the fix.
==========

[commit-bot: I haz the power, 2016-10-31 16:14:29]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-10-31 16:45:39]

Description was changed from

==========
Checking RendererThreadImpl for null when creating media player.

Also adding CHECKs for it not being nullptr in AudioDeviceFactory.
RendererThreadImpl lives in TLS, and a call to
lazy_tls.Pointer()->Get()::GetAudioRendererMixerManager()
(
https://cs.chromium.org/chromium/src/content/renderer/media/audio_device_fact...
https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?q...)
end up accessing |audio_renderer_mixer_manager_| of nullptr.

BUG=657167
TESTING=running failed clusterfuzz test locally: test passes after the fix.
==========

to

==========
Checking RendererThreadImpl for null when creating media player.

Also adding CHECKs for it not being nullptr in AudioDeviceFactory.
RendererThreadImpl lives in TLS, and a call to
lazy_tls.Pointer()->Get()::GetAudioRendererMixerManager()
(
https://cs.chromium.org/chromium/src/content/renderer/media/audio_device_fact...
https://cs.chromium.org/chromium/src/content/renderer/render_thread_impl.cc?q...)
end up accessing |audio_renderer_mixer_manager_| of nullptr.

BUG=657167
TESTING=running failed clusterfuzz test locally: test passes after the fix.

Committed: https://crrev.com/64b9793077e8daf693a06eab4b98dc5a6374630d
Cr-Commit-Position: refs/heads/master@{#428728}
==========

[commit-bot: I haz the power, 2016-10-31 16:45:40]

Patchset 2 (id:??) landed as
https://crrev.com/64b9793077e8daf693a06eab4b98dc5a6374630d
Cr-Commit-Position: refs/heads/master@{#428728}