content/renderer/media/audio_device_factory.cc - Issue 2460303003: Checking RendererThreadImpl for null when creating media player.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_device_factory.cc

Issue 2460303003: Checking RendererThreadImpl for null when creating media player. (Closed)

Patch Set: addressing review comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/audio_device_factory.cc

diff --git a/content/renderer/media/audio_device_factory.cc b/content/renderer/media/audio_device_factory.cc

index 2b06de485ee6941b49996526b7766cc5ec3813b3..1f8e161c108c62a41d8058e98344e1c00759f02b 100644

--- a/content/renderer/media/audio_device_factory.cc

+++ b/content/renderer/media/audio_device_factory.cc

@@ -72,6 +72,8 @@ scoped_refptr<media::SwitchableAudioRendererSink> NewMixableSink(

const std::string& device_id,

const url::Origin& security_origin) {

RenderThreadImpl* render_thread = RenderThreadImpl::current();

+ DCHECK(render_thread) << "RenderThreadImpl is not instantiated, or "

+ << "GetOutputDeviceInfo() is called on a wrong thread ";

return scoped_refptr<media::AudioRendererMixerInput>(

render_thread->GetAudioRendererMixerManager()->CreateInput(

render_frame_id, session_id, device_id, security_origin,

« no previous file with comments | « no previous file | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »