Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2460173003: Revert "Allow selection change update before beginBatchEdit" on M54 (Closed)

Created:
4 years, 1 month ago by aelias_OOO_until_Jul13
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert "Allow selection change update before beginBatchEdit" on M54 This reverts commit 4662007a92a92b016ef3f05fb4cbbd6904825cc0. BUG=659934 Committed: https://chromium.googlesource.com/chromium/src/+/3a680ae83d852ecf8f24b1236c67c8df855bb241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+341 lines, -216 lines) Patch
M content/browser/android/content_view_core_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/input_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/text_input_state.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/text_input_state.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java View 1 chunk +1 line, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 4 chunks +3 lines, -26 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ReplicaInputConnection.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/TextInputState.java View 4 chunks +3 lines, -9 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java View 7 chunks +9 lines, -34 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 2 chunks +9 lines, -12 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/input/TextInputStateTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
A content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionFactoryTest.java View 1 chunk +290 lines, -0 lines 0 comments Download
M content/public/android/junit/src/org/chromium/content/browser/input/ThreadedInputConnectionTest.java View 6 chunks +16 lines, -62 lines 0 comments Download
M content/renderer/render_widget.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_widget.cc View 4 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
aelias_OOO_until_Jul13
4 years, 1 month ago (2016-10-29 19:12:40 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3a680ae83d852ecf8f24b1236c67c8df855bb241.

Powered by Google App Engine
This is Rietveld 408576698