content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2460173003: Revert "Allow selection change update before beginBatchEdit" on M54

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2460173003: Revert "Allow selection change update before beginBatchEdit" on M54 (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/view_messages.h ('k') | content/public/android/java/src/org/chromium/content/browser/input/ChromiumBaseInputConnection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 6f92c8764312c8736e88d2a3cfc13c27f43cdf9d..22c8d483f82e55c4fd4669c106f42a40db091b0d 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -2323,7 +2323,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen

private void updateImeAdapter(long nativeImeAdapterAndroid, int textInputType,

int textInputFlags, String text, int selectionStart, int selectionEnd,

int compositionStart, int compositionEnd, boolean showImeIfNeeded,

- boolean isNonImeChange, boolean inBatchEditMode) {

+ boolean isNonImeChange) {

try {

TraceEvent.begin("ContentViewCore.updateImeAdapter");

boolean focusedNodeEditable = (textInputType != TextInputType.NONE);

@@ -2334,7 +2334,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen

mImeAdapter.updateKeyboardVisibility(

textInputType, textInputFlags, showImeIfNeeded);

mImeAdapter.updateState(text, selectionStart, selectionEnd, compositionStart,

- compositionEnd, isNonImeChange, inBatchEditMode);

+ compositionEnd, isNonImeChange);

if (mActionMode != null) {

final boolean actionModeConfigurationChanged =