Issue 246013008: Add proper includes for usage of the CityHash functions.

Issue 246013008: Add proper includes for usage of the CityHash functions. (Closed)

Created:
6 years, 8 months ago by mvrable

Modified:
6 years, 7 months ago

Reviewers:
Zhenyao Mo, Alexei Svitkine (slow)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, extensions-reviews_chromium.org, Steven Holte

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add proper includes for usage of the CityHash functions. Previously function declarations needed to be added manually because of build errors on Windows when including the City.h file. Now, with the build errors fixed, use the proper includes everywhere. BUG=353157 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266645

Patch Set 1 #

Patch Set 2 : Update all Cith.h #inclue sites #

Patch Set 3 : Rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
M	chrome/browser/metrics/extension_metrics.cc	View		1 chunk	+1 line, -5 lines	0 comments	Download
M	components/rappor/bloom_filter.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	1	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mvrable

This code cleanup properly includes the CityHash header file where previously function declarations were being ...

6 years, 7 months ago (2014-04-28 17:31:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mvrable@chromium.org/246013008/40001

6 years, 7 months ago (2014-04-28 18:26:41 UTC) #5

Message was sent while issue was closed.

Change committed as 266645

Expand Messages | Collapse Messages