Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: components/rappor/bloom_filter.cc

Issue 246013008: Add proper includes for usage of the CityHash functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/rappor/bloom_filter.h" 5 #include "components/rappor/bloom_filter.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 8 #include "third_party/smhasher/src/City.h"
9 // TODO(holte): we can't include "City.h" due to typedef conflicts.
10 extern uint64 CityHash64WithSeed(const char *buf, size_t len, uint64 seed);
11 9
12 namespace rappor { 10 namespace rappor {
13 11
14 BloomFilter::BloomFilter(uint32_t bytes_size, 12 BloomFilter::BloomFilter(uint32_t bytes_size,
15 uint32_t hash_function_count, 13 uint32_t hash_function_count,
16 uint32_t hash_seed_offset) 14 uint32_t hash_seed_offset)
17 : bytes_(bytes_size), 15 : bytes_(bytes_size),
18 hash_function_count_(hash_function_count), 16 hash_function_count_(hash_function_count),
19 hash_seed_offset_(hash_seed_offset) { 17 hash_seed_offset_(hash_seed_offset) {
20 DCHECK_GT(bytes_size, 0u); 18 DCHECK_GT(bytes_size, 0u);
21 } 19 }
22 20
23 BloomFilter::~BloomFilter() {} 21 BloomFilter::~BloomFilter() {}
24 22
25 void BloomFilter::AddString(const std::string& str) { 23 void BloomFilter::AddString(const std::string& str) {
26 for (size_t i = 0; i < hash_function_count_; ++i) { 24 for (size_t i = 0; i < hash_function_count_; ++i) {
27 // Using CityHash here because we have support for it in Dremel. Many hash 25 // Using CityHash here because we have support for it in Dremel. Many hash
28 // functions, such as MD5, SHA1, or Murmur, would probably also work. 26 // functions, such as MD5, SHA1, or Murmur, would probably also work.
29 uint32_t index = 27 uint32_t index =
30 CityHash64WithSeed(str.data(), str.size(), hash_seed_offset_ + i); 28 CityHash64WithSeed(str.data(), str.size(), hash_seed_offset_ + i);
31 // Note that the "bytes" are uint8_t, so they are always 8-bits. 29 // Note that the "bytes" are uint8_t, so they are always 8-bits.
32 uint32_t byte_index = (index / 8) % bytes_.size(); 30 uint32_t byte_index = (index / 8) % bytes_.size();
33 uint32_t bit_index = index % 8; 31 uint32_t bit_index = index % 8;
34 bytes_[byte_index] |= 1 << bit_index; 32 bytes_[byte_index] |= 1 << bit_index;
35 } 33 }
36 } 34 }
37 35
38 } // namespace rappor 36 } // namespace rappor
OLDNEW
« no previous file with comments | « chrome/browser/metrics/extension_metrics.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698