Issue 246013006: Remove tests for showModalDialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 246013006: Remove tests for showModalDialog (Closed)

Created:
6 years, 8 months ago by abarth-chromium

Modified:
6 years, 8 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, jamesr, eseidel

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove tests for showModalDialog This deletes the chromium-side tests for showModalDialog. We're about to disable this feature from the Blink side, which would otherwise break these tests. The plan is to leave the implementation behind a flag for a release or two in case we need to restore the feature on short notice. This CL is a partial re-land of https://codereview.chromium.org/165793003. R=darin@chromium.org BUG=345831 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265711

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -54 lines)			Patch
M	chrome/browser/ui/browser_browsertest.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	chrome/test/data/showmodaldialog.html	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	content/browser/webkit_browsertest.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
D	content/test/data/error-body-no-crash.html	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/246013006/20001

6 years, 8 months ago (2014-04-23 17:38:05 UTC) #6

Message was sent while issue was closed.

Change committed as 265711