Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2460123002: Correctly disable TestAppViewGoodDataShouldSucceed (Closed)

Created:
4 years, 1 month ago by xidachen
Modified:
4 years, 1 month ago
Reviewers:
lfg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly disable TestAppViewGoodDataShouldSucceed In my previous CL here: https://codereview.chromium.org/2447013010/, I didn't disable that test correctly, this CL correctly disable this test. BUG=660366 TBR=lfg@chromium.org NOTRY=true Committed: https://crrev.com/d27f8b995056395366afc6f09484fa44726c4d38 Cr-Commit-Position: refs/heads/master@{#428586}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/browser/guest_view/app_view/app_view_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460123002/1
4 years, 1 month ago (2016-10-29 01:47:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-29 01:52:10 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-29 01:55:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d27f8b995056395366afc6f09484fa44726c4d38
Cr-Commit-Position: refs/heads/master@{#428586}

Powered by Google App Engine
This is Rietveld 408576698