Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: extensions/browser/guest_view/app_view/app_view_apitest.cc

Issue 2460123002: Correctly disable TestAppViewGoodDataShouldSucceed (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/path_service.h" 6 #include "base/path_service.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "components/guest_view/browser/guest_view_manager.h" 8 #include "components/guest_view/browser/guest_view_manager.h"
9 #include "components/guest_view/browser/guest_view_manager_factory.h" 9 #include "components/guest_view/browser/guest_view_manager_factory.h"
10 #include "components/guest_view/browser/test_guest_view_manager.h" 10 #include "components/guest_view/browser/test_guest_view_manager.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 159
160 INSTANTIATE_TEST_CASE_P(AppViewTests, AppViewTest, testing::Bool()); 160 INSTANTIATE_TEST_CASE_P(AppViewTests, AppViewTest, testing::Bool());
161 161
162 #if defined(OS_WIN) 162 #if defined(OS_WIN)
163 #define MAYBE_TestAppViewGoodDataShouldSucceed \ 163 #define MAYBE_TestAppViewGoodDataShouldSucceed \
164 DISABLED_TestAppViewGoodDataShouldSucceed 164 DISABLED_TestAppViewGoodDataShouldSucceed
165 #else 165 #else
166 #define MAYBE_TestAppViewGoodDataShouldSucceed TestAppViewGoodDataShouldSucceed 166 #define MAYBE_TestAppViewGoodDataShouldSucceed TestAppViewGoodDataShouldSucceed
167 #endif 167 #endif
168 // Tests that <appview> correctly processes parameters passed on connect. 168 // Tests that <appview> correctly processes parameters passed on connect.
169 IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewGoodDataShouldSucceed) { 169 IN_PROC_BROWSER_TEST_P(AppViewTest, MAYBE_TestAppViewGoodDataShouldSucceed) {
170 RunTest("testAppViewGoodDataShouldSucceed", 170 RunTest("testAppViewGoodDataShouldSucceed",
171 "app_view/apitest", 171 "app_view/apitest",
172 "app_view/apitest/skeleton"); 172 "app_view/apitest/skeleton");
173 } 173 }
174 174
175 // Tests that <appview> can handle media permission requests. 175 // Tests that <appview> can handle media permission requests.
176 IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewMediaRequest) { 176 IN_PROC_BROWSER_TEST_P(AppViewTest, TestAppViewMediaRequest) {
177 static_cast<ShellExtensionsBrowserClient*>(ExtensionsBrowserClient::Get()) 177 static_cast<ShellExtensionsBrowserClient*>(ExtensionsBrowserClient::Get())
178 ->SetAPIClientForTest(nullptr); 178 ->SetAPIClientForTest(nullptr);
179 static_cast<ShellExtensionsBrowserClient*>(ExtensionsBrowserClient::Get()) 179 static_cast<ShellExtensionsBrowserClient*>(ExtensionsBrowserClient::Get())
(...skipping 23 matching lines...) Expand all
203 #endif 203 #endif
204 // Tests that <appview> is able to navigate to another installed app. 204 // Tests that <appview> is able to navigate to another installed app.
205 IN_PROC_BROWSER_TEST_P(AppViewTest, 205 IN_PROC_BROWSER_TEST_P(AppViewTest,
206 MAYBE_TestAppViewWithUndefinedDataShouldSucceed) { 206 MAYBE_TestAppViewWithUndefinedDataShouldSucceed) {
207 RunTest("testAppViewWithUndefinedDataShouldSucceed", 207 RunTest("testAppViewWithUndefinedDataShouldSucceed",
208 "app_view/apitest", 208 "app_view/apitest",
209 "app_view/apitest/skeleton"); 209 "app_view/apitest/skeleton");
210 } 210 }
211 211
212 } // namespace extensions 212 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698