Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2460103002: CrOS - Fix text background of shelf tooltips. (Closed)

Created:
4 years, 1 month ago by Evan Stade
Modified:
4 years, 1 month ago
Reviewers:
msw, varkha, Daniel Erat
CC:
chromium-reviews, groby+bubble_chromium.org, sadrul, tfarina, msw+watch_chromium.org, hcarmona+bubble_chromium.org, kalyank, rouslan+bubble_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CrOS - Fix text background of shelf tooltips. BUG=660510 Committed: https://crrev.com/17ab8262e8e13c1ace5b8270dbf71a3c7af6a7aa Cr-Commit-Position: refs/heads/master@{#428719}

Patch Set 1 #

Patch Set 2 : docs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M ash/common/shelf/shelf_tooltip_manager.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/bubble/bubble_dialog_delegate.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Evan Stade
4 years, 1 month ago (2016-10-29 00:43:33 UTC) #2
varkha
lgtm
4 years, 1 month ago (2016-10-29 00:53:02 UTC) #3
msw
lgtm
4 years, 1 month ago (2016-10-29 01:04:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460103002/20001
4 years, 1 month ago (2016-10-31 14:27:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/293078)
4 years, 1 month ago (2016-10-31 14:34:44 UTC) #8
Evan Stade
+derat for owner review of ash/common/shelf/shelf_tooltip_manager.cc
4 years, 1 month ago (2016-10-31 15:24:53 UTC) #10
Daniel Erat
lgtm subpixel-rendering-on-translucent-backgrounds is the gift that keeps giving
4 years, 1 month ago (2016-10-31 15:29:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2460103002/20001
4 years, 1 month ago (2016-10-31 15:35:40 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 15:40:28 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 15:44:54 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/17ab8262e8e13c1ace5b8270dbf71a3c7af6a7aa
Cr-Commit-Position: refs/heads/master@{#428719}

Powered by Google App Engine
This is Rietveld 408576698