Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: ui/views/bubble/bubble_dialog_delegate.cc

Issue 2460103002: CrOS - Fix text background of shelf tooltips. (Closed)
Patch Set: docs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/shelf/shelf_tooltip_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/bubble/bubble_dialog_delegate.cc
diff --git a/ui/views/bubble/bubble_dialog_delegate.cc b/ui/views/bubble/bubble_dialog_delegate.cc
index 149f21363121c25de9f410a06c614de47f48176f..5251a7ede56d99545828dd488e405d8cf46bafdf 100644
--- a/ui/views/bubble/bubble_dialog_delegate.cc
+++ b/ui/views/bubble/bubble_dialog_delegate.cc
@@ -295,11 +295,6 @@ void BubbleDialogDelegateView::UpdateColorsFromTheme(
const ui::NativeTheme* theme) {
if (!color_explicitly_set_)
color_ = theme->GetSystemColor(ui::NativeTheme::kColorId_BubbleBackground);
- // The background color is handled by the BubbleFrameView, so it shouldn't be
- // necessary to set the color on |this|. I am cowardly leaving it in place for
- // pre-MD bubbles in case this is necessary for some reason.
- if (!ui::MaterialDesignController::IsSecondaryUiMaterial())
- set_background(Background::CreateSolidBackground(color()));
BubbleFrameView* frame_view = GetBubbleFrameView();
if (frame_view)
frame_view->bubble_border()->set_background_color(color());
« no previous file with comments | « ash/common/shelf/shelf_tooltip_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698