[Devtools] Move canvas timeline out of experiments and remove old code

[Devtools] Move canvas timeline out of experiments

This patch moves the new canvas timeline out of experiments
and removes the old timeline canvas code.

R=dgozman,pfeldman
BUG=653738
Committed: https://crrev.com/ce36922953d67ded86eebf31837bfb2d002bb78d
Cr-Commit-Position: refs/heads/master@{#430358}

[allada, 2016-10-29 00:38:12]

Patchset #2 (id:20001) has been deleted

[allada, 2016-10-29 00:38:21]

Patchset #1 (id:1) has been deleted

[allada, 2016-10-29 00:53:23]

PTL

[allada, 2016-10-29 00:53:49]

Description was changed from

==========
[Devtools] Move canvas timeline out of experiments

This patch moves the new canvas timeline out of experiments
and removes the old timeline canvas code.

R=dgozman,pfeldman
BUG=653738
==========

to

==========
[Devtools] Move canvas timeline out of experiments

This patch moves the new canvas timeline out of experiments
and removes the old timeline canvas code.

R=dgozman,pfeldman
BUG=653738
==========

[dgozman, 2016-10-31 19:46:16]

Found two problems so far:
- initiators are not highlighted on timeline;
- when choosing a time window, timeline shows wrong labels.

[chowse, 2016-10-31 21:03:37]

On 2016/10/31 19:46:16, dgozman wrote:
> Found two problems so far:
> - initiators are not highlighted on timeline;
> - when choosing a time window, timeline shows wrong labels.

Some other things I ran across (on OS X):

- Right-clicking on a row causes the context menu to appear and disappear
immediately. Afterwards, the context menu does not open on right-click at all.
In Hosted Mode, right-clicking appears to open the context menu twice. 
Right-clicking appears to open 2 context menus

- In the Overview: The drag handles (on the left and right edges of the visible
area) are behaving strangely. In Stable, clicking and dragging each handle only
changes the edge that you drag. In Canary, it appears the mousedown isn't being
trapped and it starts a cursor selection at the same time, resulting in
unexpected behavior when you release the mouse.

[allada, 2016-10-31 21:42:13]

In regard to second comment (Overview), the offending patch is:
https://codereview.chromium.org/2451033002 I already notified alph to fix. (ie:
not related to this patch)
On 2016/10/31 21:03:37, chowse wrote:
> On 2016/10/31 19:46:16, dgozman wrote:
> > Found two problems so far:
> > - initiators are not highlighted on timeline;
> > - when choosing a time window, timeline shows wrong labels.
> 
> Some other things I ran across (on OS X):
> 
> - Right-clicking on a row causes the context menu to appear and disappear
> immediately. Afterwards, the context menu does not open on right-click at all.
> In Hosted Mode, right-clicking appears to open the context menu twice. 
> Right-clicking appears to open 2 context menus
> 
> - In the Overview: The drag handles (on the left and right edges of the
visible
> area) are behaving strangely. In Stable, clicking and dragging each handle
only
> changes the edge that you drag. In Canary, it appears the mousedown isn't
being
> trapped and it starts a cursor selection at the same time, resulting in
> unexpected behavior when you release the mouse.

[allada, 2016-11-01 00:02:17]

Patch to fix this issue is up here: https://codereview.chromium.org/2466163002/
On 2016/10/31 21:03:37, chowse wrote:
> On 2016/10/31 19:46:16, dgozman wrote:
...
> - Right-clicking on a row causes the context menu to appear and disappear
> immediately. Afterwards, the context menu does not open on right-click at all.
> In Hosted Mode, right-clicking appears to open the context menu twice. 
> Right-clicking appears to open 2 context menus

[allada, 2016-11-01 23:17:40]

Patchset #2 (id:60001) has been deleted

[allada, 2016-11-01 23:28:39]

Patchset #3 (id:100001) has been deleted

[allada, 2016-11-01 23:28:43]

Patchset #2 (id:80001) has been deleted

[allada, 2016-11-01 23:28:49]

Patchset #2 (id:120001) has been deleted

[allada, 2016-11-01 23:38:06]

Patchset #2 (id:140001) has been deleted

[chowse, 2016-11-01 23:55:36]

On 2016/11/01 00:02:17, Blaise wrote:
> Patch to fix this issue is up here:
https://codereview.chromium.org/2466163002/
> On 2016/10/31 21:03:37, chowse wrote:
> > On 2016/10/31 19:46:16, dgozman wrote:
> ...
> > - Right-clicking on a row causes the context menu to appear and disappear
> > immediately. Afterwards, the context menu does not open on right-click at
all.
> > In Hosted Mode, right-clicking appears to open the context menu twice. 
> > Right-clicking appears to open 2 context menus

Patch fixes the context menu, so LGTM.

[dgozman, 2016-11-02 22:40:05]

We need:
- min size for timeline widget;
- text not overlapping with triangle on the right;
- popup working in all modes.

[paulirish1, 2016-11-03 19:56:53]

Notes from me:

1. timing popup on hover is coming up seemingly randomly in simplified view ==>
add queuing bar to simplified view
2. "Timeline" => "Waterfall"
3. move Timeline/Waterfall menu to bottom of context menu
4. Header scale times => smaller font

[paulirish, 2016-11-03 20:02:07]

paulirish@chromium.org changed reviewers:
+ chowse@chromium.org, paulirish@chromium.org

[allada, 2016-11-03 22:37:31]

On 2016/11/02 22:40:05, dgozman wrote:
> We need:
> - min size for timeline widget;
patch: https://codereview.chromium.org/2468393002/
> - text not overlapping with triangle on the right;
patch: https://codereview.chromium.org/2468393002/
> - popup working in all modes.
patch: https://codereview.chromium.org/2470273002/

[allada, 2016-11-03 22:39:31]

On 2016/11/03 19:56:53, paulirish1 wrote:
> Notes from me:
> 
> 1. timing popup on hover is coming up seemingly randomly in simplified view
==>
> add queuing bar to simplified view
patch: https://codereview.chromium.org/2474233002/
> 2. "Timeline" => "Waterfall"
patch: https://codereview.chromium.org/2476573003/
> 3. move Timeline/Waterfall menu to bottom of context menu
patch: https://codereview.chromium.org/2466413007/
> 4. Header scale times => smaller font
patch: https://codereview.chromium.org/2472063003/

[allada, 2016-11-05 01:24:39]

All changes done and landed. PTL

[allada, 2016-11-05 01:24:45]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-05 01:25:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 03:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 03:14:25]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-07 18:22:57]

lgtm

https://codereview.chromium.org/2460073002/diff/180001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(left):

https://codereview.chromium.org/2460073002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:84:
this._popoverHelper.hidePopover();
Why did you remove all hidePopover calls?

[allada, 2016-11-07 18:32:12]

done

https://codereview.chromium.org/2460073002/diff/180001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(left):

https://codereview.chromium.org/2460073002/diff/180001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:84:
this._popoverHelper.hidePopover();
On 2016/11/07 18:22:56, dgozman wrote:
> Why did you remove all hidePopover calls?

Done.

[allada, 2016-11-07 18:34:39]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 18:35:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 19:59:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 19:59:39]

Dry run: This issue passed the CQ dry run.

[allada, 2016-11-07 20:15:30]

The CQ bit was checked by allada@chromium.org

[allada, 2016-11-07 20:15:30]

The patchset sent to the CQ was uploaded after l-g-t-m from chowse@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2460073002/#ps200001
(title: "changes")

[commit-bot: I haz the power, 2016-11-07 20:15:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 20:23:53]

Description was changed from

==========
[Devtools] Move canvas timeline out of experiments

This patch moves the new canvas timeline out of experiments
and removes the old timeline canvas code.

R=dgozman,pfeldman
BUG=653738
==========

to

==========
[Devtools] Move canvas timeline out of experiments

This patch moves the new canvas timeline out of experiments
and removes the old timeline canvas code.

R=dgozman,pfeldman
BUG=653738
==========

[commit-bot: I haz the power, 2016-11-07 20:23:54]

Committed patchset #4 (id:200001)

[commit-bot: I haz the power, 2016-11-07 21:18:40]

Description was changed from

==========
[Devtools] Move canvas timeline out of experiments

This patch moves the new canvas timeline out of experiments
and removes the old timeline canvas code.

R=dgozman,pfeldman
BUG=653738
==========

to

==========
[Devtools] Move canvas timeline out of experiments

This patch moves the new canvas timeline out of experiments
and removes the old timeline canvas code.

R=dgozman,pfeldman
BUG=653738

Committed: https://crrev.com/ce36922953d67ded86eebf31837bfb2d002bb78d
Cr-Commit-Position: refs/heads/master@{#430358}
==========

[commit-bot: I haz the power, 2016-11-07 21:18:41]

Patchset 4 (id:??) landed as
https://crrev.com/ce36922953d67ded86eebf31837bfb2d002bb78d
Cr-Commit-Position: refs/heads/master@{#430358}