Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2451033002: DevTools: Allow several drag handlers running simultaneously. (Closed)

Created:
4 years, 1 month ago by alph
Modified:
4 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Allow several drag handlers running simultaneously. Committed: https://crrev.com/02ffeb402ca136d2b0882b1a1e265aafab937724 Cr-Commit-Position: refs/heads/master@{#428241}

Patch Set 1 #

Patch Set 2 : keep indent + keep single glass pane #

Patch Set 3 : rebaseline #

Total comments: 1

Patch Set 4 : addressing commenta #

Patch Set 5 : fix timeline overview window selection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -57 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 2 3 2 chunks +98 lines, -57 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
alph
4 years, 1 month ago (2016-10-26 01:13:17 UTC) #3
pfeldman
lgtm https://codereview.chromium.org/2451033002/diff/60001/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js File third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js (right): https://codereview.chromium.org/2451033002/diff/60001/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js#newcode105 third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js:105: WebInspector.DragHandler._glassPane = new WebInspector.GlassPane(this._mouseOutWhileDraggingTargetDocument); _documentForMouseOut, also this will ...
4 years, 1 month ago (2016-10-26 19:30:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451033002/100001
4 years, 1 month ago (2016-10-26 23:25:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/319984)
4 years, 1 month ago (2016-10-27 01:54:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451033002/100001
4 years, 1 month ago (2016-10-27 22:11:55 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 1 month ago (2016-10-28 02:11:11 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 02:14:00 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/02ffeb402ca136d2b0882b1a1e265aafab937724
Cr-Commit-Position: refs/heads/master@{#428241}

Powered by Google App Engine
This is Rietveld 408576698