Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2459983002: Reland of Add initial CL for RandomOrder chromium.fyi bot (Closed)

Created:
4 years, 1 month ago by jeffcarp
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of Add initial CL for RandomOrder chromium.fyi bot (patchset #1 id:1 of https://codereview.chromium.org/2456053008/ ) Reason for revert: Creating re-land CL Original issue's description: > Revert of Add initial CL for RandomOrder chromium.fyi bot (patchset #6 id:100001 of https://codereview.chromium.org/2384243005/ ) > > Reason for revert: > Missed adding the new flags to the bottom of the file as well. > > http://crbug.com/660503 > > Original issue's description: > > Add initial CL for RandomOrder chromium.fyi bot > > > > This is a set of 2 CLs: > > > > 1. build CL (this one) - https://codereview.chromium.org/2384243005/ > > 2. src CL - https://codereview.chromium.org/2404573002 > > > > BUG=652357 > > > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/fc1d3b8658c112563b0c3ae7f6e3303d908fcee1 > > TBR=dpranke@chromium.org,qyearsley@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=652357 > TBR=dpranke > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/968a142609f3d261c230be4ae350e7f181c3d905 TBR=dpranke@chromium.org,qyearsley@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=652357 Committed: https://chromium.googlesource.com/chromium/tools/build/+/dd034fce24f5d8cd266cebce4a9f50700f4b3ce7

Patch Set 1 #

Patch Set 2 : Make --order default None #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -38 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 3 chunks +10 lines, -0 lines 0 comments Download
M masters/master.chromium.fyi/slaves.cfg View 1 1 chunk +8 lines, -0 lines 0 comments Download
M scripts/slave/chromium/layout_test_wrapper.py View 1 2 chunks +14 lines, -0 lines 1 comment Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 2 chunks +23 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux___RandomOrder.json View 1 18 chunks +39 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jeffcarp
Created Reland of Add initial CL for RandomOrder chromium.fyi bot
4 years, 1 month ago (2016-10-28 20:57:54 UTC) #1
qyearsley
LGTM https://codereview.chromium.org/2459983002/diff/160001/scripts/slave/chromium/layout_test_wrapper.py File scripts/slave/chromium/layout_test_wrapper.py (right): https://codereview.chromium.org/2459983002/diff/160001/scripts/slave/chromium/layout_test_wrapper.py#newcode218 scripts/slave/chromium/layout_test_wrapper.py:218: 'Only applicable in combination with --order=random.')), Note, fix ...
4 years, 1 month ago (2016-10-28 22:41:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459983002/160001
4 years, 1 month ago (2016-10-31 21:50:58 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 21:51:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:160001) as
https://chromium.googlesource.com/chromium/tools/build/+/dd034fce24f5d8cd266c...

Powered by Google App Engine
This is Rietveld 408576698