Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2404573002: Add WebKit Linux - RandomOrder bot to chromium.fyi (Closed)

Created:
4 years, 2 months ago by jeffcarp
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, qyearsley
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WebKit Linux - RandomOrder bot to chromium.fyi This is a set of 2 CLs: 1. build CL - https://codereview.chromium.org/2384243005/ 2. src CL (this one) - https://codereview.chromium.org/2404573002 BUG=652357 Committed: https://crrev.com/efc906a9cc4201e8ff94358f5a19c8da8c78d018 Cr-Commit-Position: refs/heads/master@{#428474}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 14 (5 generated)
jeffcarp
4 years, 2 months ago (2016-10-07 21:47:26 UTC) #2
jeffcarp
https://codereview.chromium.org/2404573002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2404573002/diff/1/tools/mb/mb_config.pyl#newcode179 tools/mb/mb_config.pyl:179: 'WebKit Linux - RandomOrder': 'release_bot', Is 'release_bot' the right ...
4 years, 2 months ago (2016-10-07 21:50:19 UTC) #5
Dirk Pranke
release_bot should be fine. lgtm.
4 years, 2 months ago (2016-10-08 16:54:38 UTC) #6
qyearsley
lgtm
4 years, 2 months ago (2016-10-10 22:48:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2404573002/1
4 years, 1 month ago (2016-10-28 18:34:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 20:22:22 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/efc906a9cc4201e8ff94358f5a19c8da8c78d018 Cr-Commit-Position: refs/heads/master@{#428474}
4 years, 1 month ago (2016-10-28 20:24:22 UTC) #12
Michael Achenbach
Looks like this broke layout tests across the fleet, e.g.: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise/builds/1665
4 years, 1 month ago (2016-10-28 20:51:43 UTC) #13
Michael Achenbach
4 years, 1 month ago (2016-10-28 20:52:45 UTC) #14
Message was sent while issue was closed.
On 2016/10/28 20:51:43, machenbach (slow) wrote:
> Looks like this broke layout tests across the fleet, e.g.:
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precis...

Meant the build CL, saw it was reverted...

Powered by Google App Engine
This is Rietveld 408576698