Issue 2459843002: Copy m_namespaceRules when copying StyleSheetContents to avoid crashing.

meade_UTC10

meade@chromium.org changed reviewers: + timloh@chromium.org

4 years, 1 month ago (2016-10-28 04:31:51 UTC) #1

rune

lgtm if you remove the stray test code and fix the test issues. https://codereview.chromium.org/2459843002/diff/1/third_party/WebKit/LayoutTests/fast/css/access-namespace-rule-after-delete-rule-crash.html File ...

4 years, 1 month ago (2016-10-28 07:41:16 UTC) #4

Timothy Loh

We should be able to test this more thoroughly than seeing that it doesn't crash ...

4 years, 1 month ago (2016-10-31 01:05:00 UTC) #5

meade_UTC10

On 2016/10/31 01:05:00, Timothy Loh wrote: > We should be able to test this more ...

4 years, 1 month ago (2016-10-31 01:21:42 UTC) #6

meade_UTC10

https://codereview.chromium.org/2459843002/diff/1/third_party/WebKit/LayoutTests/fast/css/access-namespace-rule-after-delete-rule-crash.html File third_party/WebKit/LayoutTests/fast/css/access-namespace-rule-after-delete-rule-crash.html (right): https://codereview.chromium.org/2459843002/diff/1/third_party/WebKit/LayoutTests/fast/css/access-namespace-rule-after-delete-rule-crash.html#newcode1 third_party/WebKit/LayoutTests/fast/css/access-namespace-rule-after-delete-rule-crash.html:1: <style>@namespace a "a"; div { }</style> On 2016/10/28 07:41:16, ...

4 years, 1 month ago (2016-10-31 01:32:53 UTC) #7

meade_UTC10

The CQ bit was checked by meade@chromium.org to run a CQ dry run

4 years, 1 month ago (2016-10-31 01:32:57 UTC) #8

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459843002/20001

4 years, 1 month ago (2016-10-31 01:33:02 UTC) #9

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 1 month ago (2016-10-31 01:35:12 UTC) #10

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/325313)

4 years, 1 month ago (2016-10-31 01:35:12 UTC) #11

meade_UTC10

The CQ bit was checked by meade@chromium.org to run a CQ dry run

4 years, 1 month ago (2016-10-31 01:42:04 UTC) #12

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459843002/60001

4 years, 1 month ago (2016-10-31 01:42:12 UTC) #13

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 1 month ago (2016-10-31 03:15:12 UTC) #14

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 1 month ago (2016-10-31 03:15:12 UTC) #15

meade_UTC10

The CQ bit was checked by meade@chromium.org to run a CQ dry run

4 years, 1 month ago (2016-11-01 03:24:33 UTC) #17

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459843002/80001

4 years, 1 month ago (2016-11-01 03:24:43 UTC) #18

Timothy Loh

lgtm, maybe -crash not needed in the test name any more? https://codereview.chromium.org/2459843002/diff/80001/third_party/WebKit/Source/core/css/StyleSheetContents.cpp File third_party/WebKit/Source/core/css/StyleSheetContents.cpp (right): ...

4 years, 1 month ago (2016-11-01 03:30:35 UTC) #19

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 1 month ago (2016-11-01 04:35:15 UTC) #20

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 1 month ago (2016-11-01 04:35:15 UTC) #21

meade_UTC10

Done. https://codereview.chromium.org/2459843002/diff/80001/third_party/WebKit/Source/core/css/StyleSheetContents.cpp File third_party/WebKit/Source/core/css/StyleSheetContents.cpp (right): https://codereview.chromium.org/2459843002/diff/80001/third_party/WebKit/Source/core/css/StyleSheetContents.cpp#newcode95 third_party/WebKit/Source/core/css/StyleSheetContents.cpp:95: // LazyParseCSS: Copying child rules is a strict ...

4 years, 1 month ago (2016-11-01 04:54:12 UTC) #22

meade_UTC10

The patchset sent to the CQ was uploaded after l-g-t-m from rune@opera.com, timloh@chromium.org Link to ...

4 years, 1 month ago (2016-11-01 04:54:39 UTC) #24

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459843002/100001

4 years, 1 month ago (2016-11-01 04:54:57 UTC) #25

commit-bot: I haz the power

Description was changed from ========== Copy m_namespaceRules when copying StyleSheetContents to avoid crashing. BUG=657457 ========== ...

4 years, 1 month ago (2016-11-01 06:22:56 UTC) #27

commit-bot: I haz the power

4 years, 1 month ago (2016-11-01 06:22:58 UTC) #28

Message was sent while issue was closed.

Patchset 6 (id:??) landed as
https://crrev.com/ca04090e0b051b730f9dc8823f0bba151ebb5bcb
Cr-Commit-Position: refs/heads/master@{#428946}

Issue 2459843002: Copy m_namespaceRules when copying StyleSheetContents to avoid crashing. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove unnecessary test code, use testharness #

Patch Set 3 : Tidy layout test code #

Patch Set 4 : Rebase #

Patch Set 5 : Make the test more detailed #

Patch Set 6 : Rename test, move comment #

Messages