Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/core/css/StyleSheetContents.cpp

Issue 2459843002: Copy m_namespaceRules when copying StyleSheetContents to avoid crashing. (Closed)
Patch Set: Make the test more detailed Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/StyleRuleNamespace.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2006, 2007, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2006, 2007, 2012 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 m_isMutable(false), 85 m_isMutable(false),
86 m_hasFontFaceRule(o.m_hasFontFaceRule), 86 m_hasFontFaceRule(o.m_hasFontFaceRule),
87 m_hasViewportRule(o.m_hasViewportRule), 87 m_hasViewportRule(o.m_hasViewportRule),
88 m_hasMediaQueries(o.m_hasMediaQueries), 88 m_hasMediaQueries(o.m_hasMediaQueries),
89 m_hasSingleOwnerDocument(true), 89 m_hasSingleOwnerDocument(true),
90 m_isUsedFromTextCache(false), 90 m_isUsedFromTextCache(false),
91 m_parserContext(o.m_parserContext) { 91 m_parserContext(o.m_parserContext) {
92 // FIXME: Copy import rules. 92 // FIXME: Copy import rules.
93 ASSERT(o.m_importRules.isEmpty()); 93 ASSERT(o.m_importRules.isEmpty());
94 94
95 // LazyParseCSS: Copying child rules is a strict point for lazy parsing, so 95 // LazyParseCSS: Copying child rules is a strict point for lazy parsing, so
Timothy Loh 2016/11/01 03:30:35 This comment should probably stay attached to the
meade_UTC10 2016/11/01 04:54:12 Done.
96 // there is no need to copy lazy parsing state here. 96 // there is no need to copy lazy parsing state here.
97 for (unsigned i = 0; i < m_namespaceRules.size(); ++i) {
98 m_namespaceRules[i] =
99 static_cast<StyleRuleNamespace*>(o.m_namespaceRules[i]->copy());
100 }
101
97 for (unsigned i = 0; i < m_childRules.size(); ++i) 102 for (unsigned i = 0; i < m_childRules.size(); ++i)
98 m_childRules[i] = o.m_childRules[i]->copy(); 103 m_childRules[i] = o.m_childRules[i]->copy();
99 } 104 }
100 105
101 StyleSheetContents::~StyleSheetContents() {} 106 StyleSheetContents::~StyleSheetContents() {}
102 107
103 void StyleSheetContents::setHasSyntacticallyValidCSSHeader(bool isValidCss) { 108 void StyleSheetContents::setHasSyntacticallyValidCSSHeader(bool isValidCss) {
104 m_hasSyntacticallyValidCSSHeader = isValidCss; 109 m_hasSyntacticallyValidCSSHeader = isValidCss;
105 } 110 }
106 111
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
669 visitor->trace(m_importRules); 674 visitor->trace(m_importRules);
670 visitor->trace(m_namespaceRules); 675 visitor->trace(m_namespaceRules);
671 visitor->trace(m_childRules); 676 visitor->trace(m_childRules);
672 visitor->trace(m_loadingClients); 677 visitor->trace(m_loadingClients);
673 visitor->trace(m_completedClients); 678 visitor->trace(m_completedClients);
674 visitor->trace(m_ruleSet); 679 visitor->trace(m_ruleSet);
675 visitor->trace(m_referencedFromResource); 680 visitor->trace(m_referencedFromResource);
676 } 681 }
677 682
678 } // namespace blink 683 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/StyleRuleNamespace.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698