Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2459773002: Add TaskScheduler to iOS Startup (Closed)

Created:
4 years, 1 month ago by robliao
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org, gab, fdoray
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TaskScheduler to iOS Startup This harmonizes TaskScheduler Startup with Chrome on other platforms. BUG=553459 Committed: https://crrev.com/020139530e2163c9617ebcae2484b0c51ea6bfd4 Cr-Commit-Position: refs/heads/master@{#428444}

Patch Set 1 #

Patch Set 2 : Rebase to e414cb39 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -3 lines) Patch
M ios/chrome/browser/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 5 chunks +68 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (16 generated)
robliao
rohitrao: Please review this change. Thanks!
4 years, 1 month ago (2016-10-27 23:16:10 UTC) #2
rohitrao (ping after 24h)
LGTM Verified that the additions to IOSChromeMainParts mirror the changes made to desktop's ChromeBrowserMain.
4 years, 1 month ago (2016-10-28 17:09:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2459773002/40001
4 years, 1 month ago (2016-10-28 18:42:15 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-10-28 18:49:53 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 19:09:15 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/020139530e2163c9617ebcae2484b0c51ea6bfd4
Cr-Commit-Position: refs/heads/master@{#428444}

Powered by Google App Engine
This is Rietveld 408576698