Add Browser Task Scheduler Flags to iOS

Add Browser Task Scheduler Flags to iOS

This harmonizes flag support for the task scheduler between desktop,
Android, and iOS.

BUG=553459, 633389
Committed: https://crrev.com/59eed1a47e068cd347c48177648e5bb4f2f66d47
Cr-Commit-Position: refs/heads/master@{#428401}

[robliao, 2016-10-24 23:59:43]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 00:00:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 00:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 00:13:47]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[robliao, 2016-10-25 00:14:36]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 00:15:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 01:00:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 01:00:55]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-10-25 01:09:52]

robliao@chromium.org changed reviewers:
+ rohitrao@chromium.org

[robliao, 2016-10-25 01:09:53]

rohitrao: Please review this CL. Thanks!

[rohitrao (ping after 24h), 2016-10-25 12:07:07]

https://codereview.chromium.org/2439383003/diff/1/ios/chrome/app/strings/ios_...
File ios/chrome/app/strings/ios_strings.grd (right):

https://codereview.chromium.org/2439383003/diff/1/ios/chrome/app/strings/ios_...
ios/chrome/app/strings/ios_strings.grd:266: <message
name="IDS_FLAGS_BROWSER_TASK_SCHEDULER_NAME"
Could you name these IDS_IOS_FLAGS_, for consistency with the other names in
this file?

https://codereview.chromium.org/2439383003/diff/1/ios/chrome/browser/about_fl...
File ios/chrome/browser/about_flags.mm (right):

https://codereview.chromium.org/2439383003/diff/1/ios/chrome/browser/about_fl...
ios/chrome/browser/about_flags.mm:61: {"browser-task-scheduler",
IDS_FLAGS_BROWSER_TASK_SCHEDULER_NAME,
Are you simply this to maintain consistency with desktop, or do you expect users
to flip this flag?

We only expose a limited set of flags on iOS, and I need to get clarification on
how we decide what makes the cut.  I'll find out today.

[robliao, 2016-10-26 17:28:19]

https://codereview.chromium.org/2439383003/diff/1/ios/chrome/app/strings/ios_...
File ios/chrome/app/strings/ios_strings.grd (right):

https://codereview.chromium.org/2439383003/diff/1/ios/chrome/app/strings/ios_...
ios/chrome/app/strings/ios_strings.grd:266: <message
name="IDS_FLAGS_BROWSER_TASK_SCHEDULER_NAME"
On 2016/10/25 12:07:07, rohitrao wrote:
> Could you name these IDS_IOS_FLAGS_, for consistency with the other names in
> this file?

Done.

https://codereview.chromium.org/2439383003/diff/1/ios/chrome/browser/about_fl...
File ios/chrome/browser/about_flags.mm (right):

https://codereview.chromium.org/2439383003/diff/1/ios/chrome/browser/about_fl...
ios/chrome/browser/about_flags.mm:61: {"browser-task-scheduler",
IDS_FLAGS_BROWSER_TASK_SCHEDULER_NAME,
On 2016/10/25 12:07:07, rohitrao wrote:
> Are you simply this to maintain consistency with desktop, or do you expect
users
> to flip this flag?
> 
> We only expose a limited set of flags on iOS, and I need to get clarification
on
> how we decide what makes the cut.  I'll find out today.

Users that plan on opting into the task scheduler all the time will flip this
flag. Since our deployment is going through Finch, there's no easy way to force
enable this feature on iOS for issue repros.

[robliao, 2016-10-26 17:28:37]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 17:29:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 17:42:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 17:42:14]

Dry run: This issue passed the CQ dry run.

[robliao, 2016-10-27 17:44:44]

On 2016/10/26 17:28:19, robliao wrote:
>
https://codereview.chromium.org/2439383003/diff/1/ios/chrome/app/strings/ios_...
> File ios/chrome/app/strings/ios_strings.grd (right):
> 
>
https://codereview.chromium.org/2439383003/diff/1/ios/chrome/app/strings/ios_...
> ios/chrome/app/strings/ios_strings.grd:266: <message
> name="IDS_FLAGS_BROWSER_TASK_SCHEDULER_NAME"
> On 2016/10/25 12:07:07, rohitrao wrote:
> > Could you name these IDS_IOS_FLAGS_, for consistency with the other names in
> > this file?
> 
> Done.
> 
>
https://codereview.chromium.org/2439383003/diff/1/ios/chrome/browser/about_fl...
> File ios/chrome/browser/about_flags.mm (right):
> 
>
https://codereview.chromium.org/2439383003/diff/1/ios/chrome/browser/about_fl...
> ios/chrome/browser/about_flags.mm:61: {"browser-task-scheduler",
> IDS_FLAGS_BROWSER_TASK_SCHEDULER_NAME,
> On 2016/10/25 12:07:07, rohitrao wrote:
> > Are you simply this to maintain consistency with desktop, or do you expect
> users
> > to flip this flag?
> > 
> > We only expose a limited set of flags on iOS, and I need to get
clarification
> on
> > how we decide what makes the cut.  I'll find out today.
> 
> Users that plan on opting into the task scheduler all the time will flip this
> flag. Since our deployment is going through Finch, there's no easy way to
force
> enable this feature on iOS for issue repros.

Ping! Thanks!

[robliao, 2016-10-27 19:09:21]

The CQ bit was checked by robliao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 19:09:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 19:19:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 19:19:34]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2016-10-28 17:05:05]

lgtm

[robliao, 2016-10-28 17:07:03]

The CQ bit was checked by robliao@chromium.org

[commit-bot: I haz the power, 2016-10-28 17:07:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 17:12:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-28 17:22:04]

Description was changed from

==========
Add Browser Task Scheduler Flags to iOS

This harmonizes flag support for the task scheduler between desktop,
Android, and iOS.

BUG=553459,633389
==========

to

==========
Add Browser Task Scheduler Flags to iOS

This harmonizes flag support for the task scheduler between desktop,
Android, and iOS.

BUG=553459,633389

Committed: https://crrev.com/59eed1a47e068cd347c48177648e5bb4f2f66d47
Cr-Commit-Position: refs/heads/master@{#428401}
==========

[commit-bot: I haz the power, 2016-10-28 17:22:05]

Patchset 2 (id:??) landed as
https://crrev.com/59eed1a47e068cd347c48177648e5bb4f2f66d47
Cr-Commit-Position: refs/heads/master@{#428401}