Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 245973004: Changes the expectations of shared-worker-lifecycle.html layout test. (Closed)

Created:
6 years, 8 months ago by horo
Modified:
6 years, 8 months ago
Reviewers:
kinuko
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Changes the expectations of shared-worker-lifecycle.html layout test. Expectations changes due to switiching to In-renderer Shared Worker. After https://codereview.chromium.org/240843002/ is landed, I will remove the added line in TestExpectations. BUG=327256 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172115

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/workers/shared-worker-lifecycle-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
horo
kinuko@ Could you please review?
6 years, 8 months ago (2014-04-22 01:23:35 UTC) #1
kinuko
On 2014/04/22 01:23:35, horo wrote: > kinuko@ > Could you please review? lgtm
6 years, 8 months ago (2014-04-22 03:02:04 UTC) #2
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-04-22 03:49:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/245973004/1
6 years, 8 months ago (2014-04-22 03:49:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 03:49:39 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-22 03:49:39 UTC) #6
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-04-22 03:57:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/245973004/20001
6 years, 8 months ago (2014-04-22 03:58:14 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 05:04:06 UTC) #9
Message was sent while issue was closed.
Change committed as 172115

Powered by Google App Engine
This is Rietveld 408576698