Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Issue 240843002: Reverse the embedded-shared-worker flag to turn the feature on by default. (Closed)

Created:
6 years, 8 months ago by horo
Modified:
6 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reverse the embedded-shared-worker flag to turn the feature on by default. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265251

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/worker_host/test/worker_browsertest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/worker_host/worker_service_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
horo
kinuko@ Could you please review?
6 years, 8 months ago (2014-04-22 01:24:03 UTC) #1
kinuko
https://codereview.chromium.org/240843002/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/240843002/diff/40001/chrome/app/generated_resources.grd#newcode6797 chrome/app/generated_resources.grd:6797: + Disable experimental In-renderer Shared Worker allowing to run ...
6 years, 8 months ago (2014-04-22 03:38:25 UTC) #2
horo
https://codereview.chromium.org/240843002/diff/40001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/240843002/diff/40001/chrome/app/generated_resources.grd#newcode6797 chrome/app/generated_resources.grd:6797: + Disable experimental In-renderer Shared Worker allowing to run ...
6 years, 8 months ago (2014-04-22 03:53:08 UTC) #3
kinuko
lgtm
6 years, 8 months ago (2014-04-22 04:01:37 UTC) #4
horo
jochen@ Could you please review content/public/common/content_switches.*?
6 years, 8 months ago (2014-04-22 04:41:13 UTC) #5
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-22 06:50:13 UTC) #6
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-04-22 06:50:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/240843002/60001
6 years, 8 months ago (2014-04-22 06:51:27 UTC) #8
horo
The CQ bit was unchecked by horo@chromium.org
6 years, 8 months ago (2014-04-22 06:51:36 UTC) #9
horo
The CQ bit was checked by horo@chromium.org
6 years, 8 months ago (2014-04-22 12:52:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/240843002/60001
6 years, 8 months ago (2014-04-22 12:52:41 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 14:28:10 UTC) #12
Message was sent while issue was closed.
Change committed as 265251

Powered by Google App Engine
This is Rietveld 408576698