[Mac] Refactor the Fullscreen Toolbar Visibility Locks

[Mac] Refactor the Fullscreen Toolbar Visibility Locks

No intended behavioral changes.
Moved the visibility lock code from BrowserWindowController into a new
class.
Renamed the methods so that it's more consistent

BUG=643418
Committed: https://crrev.com/32c3cd6f3babfda3bac5c8f5dbae07c07bf9aa38
Cr-Commit-Position: refs/heads/master@{#428781}

[spqchan, 2016-10-27 23:21:25]

Description was changed from

==========
[Mac] Refactor the Visibility Locks

BUG=
==========

to

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

BUG=
==========

[spqchan, 2016-10-27 23:21:42]

Description was changed from

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

BUG=
==========

to

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

BUG=643418
==========

[spqchan, 2016-10-27 23:23:12]

The CQ bit was checked by spqchan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 23:23:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 00:48:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 00:48:30]

Dry run: This issue passed the CQ dry run.

[spqchan, 2016-10-28 03:30:50]

spqchan@chromium.org changed reviewers:
+ erikchen@chromium.org

[spqchan, 2016-10-28 03:30:51]

PTAL

[spqchan, 2016-10-28 04:18:07]

Description was changed from

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

BUG=643418
==========

to

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

Moved the visibility lock code from BrowserWindowController into a new
class.
Renamed the methods so that it's more consistent

BUG=643418
==========

[erikchen, 2016-10-28 16:59:10]

lgtm

[erikchen, 2016-10-28 16:59:45]

It looks like there's no behavior change. It helps if you call this out in your
CL description. I prefer to make the top line:

No intended behavioral changes.

[erikchen, 2016-10-28 16:59:58]

On 2016/10/28 16:59:45, erikchen wrote:
> It looks like there's no behavior change. It helps if you call this out in
your
> CL description. I prefer to make the top line:
> 
> No intended behavioral changes.

err, the second to top line, since hte top line is the title

[spqchan, 2016-10-28 17:00:04]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-10-28 17:00:05]

thanks!

+rsesek for ownership

https://codereview.chromium.org/2459653005/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (left):

https://codereview.chromium.org/2459653005/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:371: 
FYI, I removed these because we no longer show the toolbar when we enter
immersive fullscreen. So this is pretty much dead.

[spqchan, 2016-10-28 17:02:34]

Description was changed from

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

Moved the visibility lock code from BrowserWindowController into a new
class.
Renamed the methods so that it's more consistent

BUG=643418
==========

to

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

No intended behavioral changes.
Moved the visibility lock code from BrowserWindowController into a new
class.
Renamed the methods so that it's more consistent

BUG=643418
==========

[Robert Sesek, 2016-10-31 18:09:59]

LGTM

https://codereview.chromium.org/2459653005/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller.h (right):

https://codereview.chromium.org/2459653005/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller.h:573:
fullscreenToolbarVisibilityLockController;
Does this need to be public?

[spqchan, 2016-10-31 18:26:24]

Thanks!

https://codereview.chromium.org/2459653005/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller.h (right):

https://codereview.chromium.org/2459653005/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller.h:573:
fullscreenToolbarVisibilityLockController;
On 2016/10/31 18:09:59, Robert Sesek wrote:
> Does this need to be public?

Moved to private

[spqchan, 2016-10-31 18:26:38]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-10-31 18:26:39]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/2459653005/#ps40001
(title: "Fix for rsesek")

[commit-bot: I haz the power, 2016-10-31 18:27:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 19:08:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 19:08:03]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[spqchan, 2016-10-31 19:43:21]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-10-31 19:43:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:15:27]

Description was changed from

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

No intended behavioral changes.
Moved the visibility lock code from BrowserWindowController into a new
class.
Renamed the methods so that it's more consistent

BUG=643418
==========

to

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

No intended behavioral changes.
Moved the visibility lock code from BrowserWindowController into a new
class.
Renamed the methods so that it's more consistent

BUG=643418
==========

[commit-bot: I haz the power, 2016-10-31 20:15:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-31 20:19:29]

Description was changed from

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

No intended behavioral changes.
Moved the visibility lock code from BrowserWindowController into a new
class.
Renamed the methods so that it's more consistent

BUG=643418
==========

to

==========
[Mac] Refactor the Fullscreen Toolbar Visibility Locks

No intended behavioral changes.
Moved the visibility lock code from BrowserWindowController into a new
class.
Renamed the methods so that it's more consistent

BUG=643418

Committed: https://crrev.com/32c3cd6f3babfda3bac5c8f5dbae07c07bf9aa38
Cr-Commit-Position: refs/heads/master@{#428781}
==========

[commit-bot: I haz the power, 2016-10-31 20:19:30]

Patchset 3 (id:??) landed as
https://crrev.com/32c3cd6f3babfda3bac5c8f5dbae07c07bf9aa38
Cr-Commit-Position: refs/heads/master@{#428781}