chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm - Issue 2459653005: [Mac] Refactor the Fullscreen Toolbar Visibility Locks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

Issue 2459653005: [Mac] Refactor the Fullscreen Toolbar Visibility Locks (Closed)

Patch Set: Fix for rsesek Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm ('k') | chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

index 83126cf2e5eee10622c834fac7b0c7ca7142aed2..3f0aad34ebe5ecfe13a6cfefb564a9e7c860a3e9 100644

--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm

@@ -324,8 +324,8 @@ BOOL ThePasteboardIsTooDamnBig() {

// responder dance between the field and the field editor is a little

// weird.)

[[BrowserWindowController browserWindowControllerForView:field]

- lockBarVisibilityForOwner:field

- withAnimation:YES];

+ lockToolbarVisibilityForOwner:field

+ withAnimation:YES];

}

return doAccept;

}

@@ -338,8 +338,8 @@ BOOL ThePasteboardIsTooDamnBig() {

if (doResign && field) {

// Give the text field ownership of the visibility lock.

[[BrowserWindowController browserWindowControllerForView:field]

- releaseBarVisibilityForOwner:field

- withAnimation:YES];

+ releaseToolbarVisibilityForOwner:field

+ withAnimation:YES];

AutocompleteTextFieldObserver* observer = [self observer];

if (observer)