src/pdf/SkPDFDeviceFlattener.cpp - Issue 245963010: Move SkShader::fLocalMatrix into SkShader constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFDeviceFlattener.cpp

Issue 245963010: Move SkShader::fLocalMatrix into SkShader constructor. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: add SkLocalMatrixShaderWrapper Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFDeviceFlattener.cpp

diff --git a/src/pdf/SkPDFDeviceFlattener.cpp b/src/pdf/SkPDFDeviceFlattener.cpp

index 91c9803c320a583c31c262b97a86bbe85cab7f15..02f2aa725219380bb4f6ce46f083182757687e8d 100644

--- a/src/pdf/SkPDFDeviceFlattener.cpp

+++ b/src/pdf/SkPDFDeviceFlattener.cpp

@@ -27,7 +27,7 @@ static void flattenPaint(const SkDraw& d, SkPaint* paint) {

if (paint->getShader()) {

SkMatrix local = paint->getShader()->getLocalMatrix();

local.preConcat(*d.fMatrix);

- paint->getShader()->setLocalMatrix(local);

+ paint->setShader(SkShader::CreateLocalMatrixWrapper(paint->getShader(), local));

scroggo 2014/04/24 17:02:53 Don't we need to unref this new shader?

}