Move SkShader::fLocalMatrix into SkShader constructor.

src/effects/SkRectShaderImageFilter.cpp

Index: src/effects/SkRectShaderImageFilter.cpp
diff --git a/src/effects/SkRectShaderImageFilter.cpp b/src/effects/SkRectShaderImageFilter.cpp
index 13e59c2c278177178a514dc77d3a19e8689b7d0f..15de520386f3ac69290c15642fc06c83d751492e 100644
--- a/src/effects/SkRectShaderImageFilter.cpp
+++ b/src/effects/SkRectShaderImageFilter.cpp
@@ -67,10 +67,9 @@ bool SkRectShaderImageFilter::onFilterImage(Proxy* proxy,
     }
     SkCanvas canvas(device.get());
     SkPaint paint;
-    paint.setShader(fShader);
     SkMatrix matrix(ctx.ctm());
     matrix.postTranslate(SkIntToScalar(-bounds.left()), SkIntToScalar(-bounds.top()));
-    fShader->setLocalMatrix(matrix);
+    paint.setShader(SkShader::CreateLocalMatrixWrapper(fShader, matrix));

[scroggo, 2014/04/24 17:02:53]

Don't we need to unref this shader? (Previously we were just passing fShader,
which we would unref later, but now we've created a new one.)

[Dominik Grewe, 2014/04/24 17:16:47]

Yeah, I think you're right.

     SkRect rect = SkRect::MakeWH(SkIntToScalar(bounds.width()), SkIntToScalar(bounds.height()));
     canvas.drawRect(rect, paint);
     *result = device.get()->accessBitmap(false);