src/effects/SkRectShaderImageFilter.cpp - Issue 245963010: Move SkShader::fLocalMatrix into SkShader constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkRectShaderImageFilter.cpp

Issue 245963010: Move SkShader::fLocalMatrix into SkShader constructor. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: uncomment setLocalMatrix Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkRectShaderImageFilter.cpp

diff --git a/src/effects/SkRectShaderImageFilter.cpp b/src/effects/SkRectShaderImageFilter.cpp

index 13e59c2c278177178a514dc77d3a19e8689b7d0f..e02401127b284764506a5f6acc67ca0b8dec95b2 100644

--- a/src/effects/SkRectShaderImageFilter.cpp

+++ b/src/effects/SkRectShaderImageFilter.cpp

@@ -70,6 +70,7 @@ bool SkRectShaderImageFilter::onFilterImage(Proxy* proxy,

paint.setShader(fShader);

SkMatrix matrix(ctx.ctm());

matrix.postTranslate(SkIntToScalar(-bounds.left()), SkIntToScalar(-bounds.top()));

+ // TODO(dominikg): How to handle this? Wrapper?

fShader->setLocalMatrix(matrix);

SkRect rect = SkRect::MakeWH(SkIntToScalar(bounds.width()), SkIntToScalar(bounds.height()));

canvas.drawRect(rect, paint);