gm/giantbitmap.cpp - Issue 245963010: Move SkShader::fLocalMatrix into SkShader constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/giantbitmap.cpp

Issue 245963010: Move SkShader::fLocalMatrix into SkShader constructor. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: nit Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/giantbitmap.cpp

diff --git a/gm/giantbitmap.cpp b/gm/giantbitmap.cpp

index c284809b16af530e3bb5557f774d50000d3d094c..ed4190a8145e0248a12e4e7cc17bfb018ceaf568 100644

--- a/gm/giantbitmap.cpp

+++ b/gm/giantbitmap.cpp

@@ -95,7 +95,6 @@ protected:

virtual void onDraw(SkCanvas* canvas) {

SkPaint paint;

- SkShader* s = SkShader::CreateBitmapShader(getBitmap(), fMode, fMode);

SkMatrix m;

if (fDoRotate) {

@@ -106,7 +105,7 @@ protected:

SkScalar scale = 11*SK_Scalar1/12;

m.setScale(scale, scale);

}

- s->setLocalMatrix(m);

+ SkShader* s = SkShader::CreateBitmapShader(getBitmap(), fMode, fMode, &m);

paint.setShader(s)->unref();

paint.setFilterLevel(fDoFilter ? SkPaint::kLow_FilterLevel : SkPaint::kNone_FilterLevel);

« no previous file with comments | « gm/drawbitmaprect.cpp ('k') | gm/gradient_matrix.cpp » ('j') | no next file with comments »