Clean up some uses of Failures and MaybeObjects.

Clean up some uses of Failures and MaybeObjects.

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20914

[Yang, 2014-04-23 07:59:01]

On 2014/04/22 13:48:43, Yang wrote:

Updated with some more changes.

[Michael Starzinger, 2014-04-23 14:34:51]

LGTM with comments.

https://codereview.chromium.org/245963007/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/245963007/diff/20001/src/objects.h#newcode1680
src/objects.h:1680: //   01 NOT_FOUND
nit: This NOT_FOUND constant doesn't seem to exist, can we drop it from the
comment?

https://codereview.chromium.org/245963007/diff/20001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/245963007/diff/20001/src/spaces.h#newcode1725
src/spaces.h:1725: // in this space, or Failure::Exception() if it is not. The
implementation
Comment is outdated.

https://codereview.chromium.org/245963007/diff/20001/src/spaces.h#newcode1728
src/spaces.h:1728: MUST_USE_RESULT Object* FindObject(Address addr);
nit: I think the MUST_USE_RESULT is overzealous here.

https://codereview.chromium.org/245963007/diff/20001/src/spaces.h#newcode2844
src/spaces.h:2844: // Finds an object for a given address, returns
Failure::Exception()
Comment is outdated.

[Yang, 2014-04-23 15:07:55]

https://codereview.chromium.org/245963007/diff/20001/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/245963007/diff/20001/src/objects.h#newcode1680
src/objects.h:1680: //   01 NOT_FOUND
On 2014/04/23 14:34:52, Michael Starzinger wrote:
> nit: This NOT_FOUND constant doesn't seem to exist, can we drop it from the
> comment?

This was there in the first patch set. Forgot to remove. Done.

https://codereview.chromium.org/245963007/diff/20001/src/spaces.h
File src/spaces.h (right):

https://codereview.chromium.org/245963007/diff/20001/src/spaces.h#newcode1725
src/spaces.h:1725: // in this space, or Failure::Exception() if it is not. The
implementation
On 2014/04/23 14:34:52, Michael Starzinger wrote:
> Comment is outdated.

Done.

https://codereview.chromium.org/245963007/diff/20001/src/spaces.h#newcode1728
src/spaces.h:1728: MUST_USE_RESULT Object* FindObject(Address addr);
On 2014/04/23 14:34:52, Michael Starzinger wrote:
> nit: I think the MUST_USE_RESULT is overzealous here.

Done.

https://codereview.chromium.org/245963007/diff/20001/src/spaces.h#newcode2844
src/spaces.h:2844: // Finds an object for a given address, returns
Failure::Exception()
On 2014/04/23 14:34:52, Michael Starzinger wrote:
> Comment is outdated.

Done.

[Yang, 2014-04-23 15:08:22]

Committed patchset #3 manually as r20914 (presubmit successful).