Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: src/accessors.h

Issue 245963007: Clean up some uses of Failures and MaybeObjects. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: address comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 108
109 // Returns true for properties that are accessors to object fields. 109 // Returns true for properties that are accessors to object fields.
110 // If true, *object_offset contains offset of object field. 110 // If true, *object_offset contains offset of object field.
111 template <class T> 111 template <class T>
112 static bool IsJSObjectFieldAccessor(typename T::TypeHandle type, 112 static bool IsJSObjectFieldAccessor(typename T::TypeHandle type,
113 Handle<String> name, 113 Handle<String> name,
114 int* object_offset); 114 int* object_offset);
115 115
116 private: 116 private:
117 // Accessor functions only used through the descriptor. 117 // Accessor functions only used through the descriptor.
118 static MaybeObject* FunctionSetPrototype(Isolate* isolate, 118 static Object* FunctionSetPrototype(Isolate* isolate,
119 JSObject* object, 119 JSObject* object,
120 Object*, 120 Object*,
121 void*); 121 void*);
122 static MaybeObject* FunctionGetPrototype(Isolate* isolate, 122 static Object* FunctionGetPrototype(Isolate* isolate,
123 Object* object, 123 Object* object,
124 void*); 124 void*);
125 static MaybeObject* FunctionGetLength(Isolate* isolate, 125 static Object* FunctionGetLength(Isolate* isolate,
126 Object* object, 126 Object* object,
127 void*); 127 void*);
128 static MaybeObject* FunctionGetName(Isolate* isolate, Object* object, void*); 128 static Object* FunctionGetName(Isolate* isolate, Object* object, void*);
129 static MaybeObject* FunctionGetArguments(Isolate* isolate, 129 static Object* FunctionGetArguments(Isolate* isolate,
130 Object* object, 130 Object* object,
131 void*); 131 void*);
132 static MaybeObject* FunctionGetCaller(Isolate* isolate, 132 static Object* FunctionGetCaller(Isolate* isolate,
133 Object* object, 133 Object* object,
134 void*); 134 void*);
135 static MaybeObject* ArraySetLength(Isolate* isolate, 135 static Object* ArraySetLength(Isolate* isolate,
136 JSObject* object, 136 JSObject* object,
137 Object*, 137 Object*,
138 void*); 138 void*);
139 static MaybeObject* ArrayGetLength(Isolate* isolate, Object* object, void*); 139 static Object* ArrayGetLength(Isolate* isolate, Object* object, void*);
140 140
141 // Helper functions. 141 // Helper functions.
142 static Handle<Object> FlattenNumber(Isolate* isolate, Handle<Object> value); 142 static Handle<Object> FlattenNumber(Isolate* isolate, Handle<Object> value);
143 static MaybeObject* IllegalSetter(Isolate* isolate, 143 static Object* IllegalSetter(Isolate* isolate,
144 JSObject*, 144 JSObject*,
145 Object*, 145 Object*,
146 void*); 146 void*);
147 static Object* IllegalGetAccessor(Isolate* isolate, Object* object, void*); 147 static Object* IllegalGetAccessor(Isolate* isolate, Object* object, void*);
148 static MaybeObject* ReadOnlySetAccessor(Isolate* isolate, 148 static Object* ReadOnlySetAccessor(Isolate* isolate,
149 JSObject*, 149 JSObject*,
150 Object* value, 150 Object* value,
151 void*); 151 void*);
152 }; 152 };
153 153
154 } } // namespace v8::internal 154 } } // namespace v8::internal
155 155
156 #endif // V8_ACCESSORS_H_ 156 #endif // V8_ACCESSORS_H_
OLDNEW
« no previous file with comments | « no previous file | src/accessors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698